Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Project Automation and Infra Updates #1168

Merged

Conversation

jarmak-nv
Copy link
Contributor

@jarmak-nv jarmak-nv commented Aug 31, 2023

Description

Closes #1093
Closes #1109

This PR creates a suite of new GitHub project automations to make our lives easier, and updates the issue templates. For reference on the project automations, please see CCCL's workflows.

Issue Template Updates

bug_report.yml

feature_request.yml

  • Removes the section on alternative approaches
    • Nobody used this (internal or external) and I don't think it adds value to have all the extra space. If someone wants to discuss alternatives, there's still the "misc" box at the end

Project Automation Updates

label_external_issues

I've updated the action to label external issues with both external This issue was filed by someone outside of the Morpheus team and Needs Triage Need team to review and classify . Doing so allows us to remove the Needs Triage Need team to review and classify label but still track through Slack integrations on the external This issue was filed by someone outside of the Morpheus team label.

Right now if we want it to continually be integrated in Slack it would need to keep Needs Triage Need team to review and classify in perpetuity which is inaccurate and makes the Triage view in the project messy. An issue we've put in the backlog is no longer in need of triage!

project_automation_set_in_progress

This action runs when a PR is opened, converted to a draft, or a review requests changes. It:

  • Sets the PR to a draft if changes are requested by the review
  • Sets the PR and linked issues to In Progress
    • Except in the case of a PR being opened as not a draft, then we set these to In Review
  • Checks if there's a Start Sprint, if not, it sets it to the current Start Sprint
  • Sets the Working Sprint to the current Working Sprint

project_automation_set_in_review

This action runs when a PR is marked Ready for Review - promoting from a draft triggers this action. It:

  • Sets the PR and linked issues to In Review

project_automation_synchronize_issues

This action runs when a PR is edited, we're interested here because we should be editing in closing keywords for issues if new or old issues are realized to be closed by this PR. It:

  • Finds the current Status Start Sprint and End Sprint from the PR
  • Sets all linked issues to the same values

project_automation_set_roadmap

This action runs on PR or Issue close. It:

  • Sets the Issue/PR roadmap field to the current roadmap
    • Technically, it sets it to the top value in the Roadmap dropdown, so we just need to continue to be diligent in updating that on release

project_automation_track_pr_dates

This action runs on PR open/close/ready for review. It:

  • Sets the Start Date/Review Start Date/End Date field for the PR in the project. This way we never need to touch it, but we can get an idea of how long PRs are in the review stage, or how long in general it takes for one to get opened and then moved into a ready for review state.

When it can, it uses dates in the PR metadata, but a GHA doesn't actually have a date associated with it so we use opened/closed dates. For review, we format the date in a little shell command and store it in an environment variable, in EST.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes. N/A
  • The documentation is up to date with these changes. N/A

@jarmak-nv jarmak-nv requested a review from a team as a code owner August 31, 2023 17:10
@jarmak-nv jarmak-nv self-assigned this Aug 31, 2023
@jarmak-nv jarmak-nv added non-breaking Non-breaking change feature request New feature or request labels Aug 31, 2023
@jarmak-nv
Copy link
Contributor Author

jarmak-nv commented Sep 6, 2023

Adding a do not merge label to this until I have a minute to add in fixes I'm making for CCCL around:

Done in a37cc6d

@jarmak-nv jarmak-nv added the DO NOT MERGE PR should not be merged; see PR for details label Sep 6, 2023
@jarmak-nv jarmak-nv removed the DO NOT MERGE PR should not be merged; see PR for details label Sep 6, 2023
@jarmak-nv
Copy link
Contributor Author

jarmak-nv commented Sep 7, 2023

Remove checkboxes from PR template and replace with I confirm by submitting...

Edit: Done in 65f54dc

@jarmak-nv
Copy link
Contributor Author

New issue to label for skip ci

@jarmak-nv
Copy link
Contributor Author

jarmak-nv commented Sep 7, 2023

Add Project_Automation prefix to all workflow names

Edit: For brevity, I prefixed with Project - in 65f54dc

@jarmak-nv
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit a19bd6d into nv-morpheus:branch-23.11 Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request non-breaking Non-breaking change
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[FEA]: GitHub Issue Form Installation Method update [FEA]: Project automation improvements
2 participants