Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RSS Source Stage for Reading RSS Feeds #1149

Merged
merged 15 commits into from
Sep 5, 2023
Merged

RSS Source Stage for Reading RSS Feeds #1149

merged 15 commits into from
Sep 5, 2023

Conversation

bsuryadevara
Copy link
Contributor

@bsuryadevara bsuryadevara commented Aug 23, 2023 •
edited
Loading

  • RSS Source Stage implementation and tests

closes #1143

@bsuryadevara bsuryadevara added non-breaking Non-breaking change feature request New feature or request 2 - In Progress labels Aug 23, 2023
@bsuryadevara bsuryadevara linked an issue Aug 23, 2023 that may be closed by this pull request
[FEA]: Add RSS Source Stage for reading from RSS feeds #1143
Closed
2 tasks
mdemoret-nv
mdemoret-nv reviewed Aug 23, 2023
View reviewed changes
Copy link
Contributor

@mdemoret-nv mdemoret-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start. Just one change so far. Next expand to a module as well.

morpheus/stages/input/rss_source_stage.py Outdated Show resolved Hide resolved
@bsuryadevara bsuryadevara marked this pull request as ready for review August 25, 2023 16:43
@bsuryadevara bsuryadevara requested a review from a team as a code owner August 25, 2023 16:43
@bsuryadevara bsuryadevara self-assigned this Aug 25, 2023
@bsuryadevara bsuryadevara added this to the 23.11 - Sherlock milestone Aug 25, 2023
mdemoret-nv
mdemoret-nv approved these changes Aug 28, 2023
View reviewed changes
morpheus/stages/input/rss_source_stage.py Outdated Show resolved Hide resolved
morpheus/stages/input/rss_source_stage.py Outdated Show resolved Hide resolved
morpheus/utils/controllers/rss_controller.py Outdated Show resolved Hide resolved
morpheus/utils/controllers/rss_controller.py Outdated Show resolved Hide resolved
morpheus/utils/controllers/rss_controller.py Outdated Show resolved Hide resolved
tests/test_rss_source_pipe.py Outdated Show resolved Hide resolved
tests/test_rss_source_pipe.py Outdated Show resolved Hide resolved
@bsuryadevara
Copy link
Contributor Author

/ok to test

@copy-pr-bot
Copy link

copy-pr-bot bot commented Aug 29, 2023

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@mdemoret-nv
Copy link
Contributor

/ok to test

@mdemoret-nv
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit 214232c into nv-morpheus:branch-23.11 Sep 5, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdemoret-nv mdemoret-nv mdemoret-nv approved these changes

Assignees

@bsuryadevara bsuryadevara

Labels
feature request New feature or request non-breaking Non-breaking change
Projects
Morpheus Boards
Archived in project
Milestone
23.11 - Sherlock
Development

Successfully merging this pull request may close these issues.

[FEA]: Add RSS Source Stage for reading from RSS feeds
2 participants
@bsuryadevara @mdemoret-nv