Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

23.07 doc fixes #1071

Merged
merged 53 commits into from
Jul 20, 2023
Merged

23.07 doc fixes #1071

merged 53 commits into from
Jul 20, 2023

Conversation

dagardner-nv
Copy link
Contributor

@dagardner-nv dagardner-nv commented Jul 19, 2023 •
edited
Loading

Description

  • Update minimum driver version to match rapids 23.06
  • Update example Kafka output
  • Update docstring for DeserializeStage such that it reads better on the CLI
  • Prevent property methods from being displayed side-by-side
  • Fix broken code snippet in docs/source/developer_guide/guides/3_simple_cpp_stage.md, create a unittest mimicking the snippet to prevent it from going out of date again.
  • Fix doscstrings to match function signatures
  • Misc other fixes

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@dagardner-nv dagardner-nv requested a review from a team as a code owner July 19, 2023 15:49
@dagardner-nv dagardner-nv mentioned this pull request Jul 19, 2023
Closed
3 tasks
@dagardner-nv dagardner-nv self-assigned this Jul 19, 2023
@dagardner-nv dagardner-nv added non-breaking Non-breaking change doc Improvements or additions to documentation 2 - In Progress labels Jul 19, 2023
@dagardner-nv dagardner-nv added the Merge After Dependencies PR is completed and reviewed but depends on another PR; do not merge out of order label Jul 19, 2023
@dagardner-nv
Copy link
Contributor Author

prop_methods
Example of tiled property methods

@dagardner-nv
Add parquet to list of supported extensions
cd687c7
@dagardner-nv
npl and fil are no longer our only two pipeline modes.
2e3f332 
Add CSV & Parquet formats as supported by the from-file stage

Use other pipeline mode for identity examples, to remove assumptions about class labels from ourput
Update FQN name for MultiMessage
@dagardner-nv
Use pipeline-other for examples not using a model, set log level to i…
b17de1d 
…nfo when using a monitor stage, and document how monitor omits itself based on the log level
@dagardner-nv
Remove unused ignore
1abbf21
@dagardner-nv
Fix minimum driver version and fix indentation of closing back-ticks
be77b1d
@dagardner-nv
Display urls as links, put them in a bullet list
a247e68
@dagardner-nv
Add parquet format, and sort filetypes
574ad11
@dagardner-nv
Change syntax so that it isn't incorrectly highlighting text as python
083e705
@dagardner-nv
Update to match formatting of example
3061e95
mdemoret-nv
mdemoret-nv approved these changes Jul 20, 2023
View reviewed changes
Copy link
Contributor

@mdemoret-nv mdemoret-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for the update.

@mdemoret-nv
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit 1384595 into nv-morpheus:branch-23.07 Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efajardo-nv efajardo-nv efajardo-nv approved these changes

@mdemoret-nv mdemoret-nv mdemoret-nv approved these changes

@drobison00 drobison00 drobison00 approved these changes

Assignees

@dagardner-nv dagardner-nv

Labels
doc Improvements or additions to documentation non-breaking Non-breaking change
Projects
Morpheus Boards
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dagardner-nv @mdemoret-nv @drobison00 @efajardo-nv @cwharris