Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt s3fs 2023.6 per #1022 #1023

Merged
merged 8 commits into from
Jul 11, 2023

Conversation

dagardner-nv
Copy link
Contributor

@dagardner-nv dagardner-nv commented Jul 7, 2023

Description

fixes #1022

TODO:

  • Test building DFP container

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@dagardner-nv dagardner-nv added bug Something isn't working non-breaking Non-breaking change 2 - In Progress labels Jul 7, 2023
@dagardner-nv dagardner-nv requested a review from a team as a code owner July 7, 2023 00:03
@dagardner-nv dagardner-nv self-assigned this Jul 7, 2023
Copy link
Contributor

@mdemoret-nv mdemoret-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a test that exercises the behavior in #1022? Otherwise this looks good.

@pdmack
Copy link
Contributor

pdmack commented Jul 7, 2023

#0 22.73 Looking for: ['boto3', 'dask', 'dill', 'distributed', 'kfp', 'librdkafka', "mlflow[version='>1.29.0,<2']", 'nodejs=17.4.0', 'papermill', 's3fs==2023.6']
#0 22.73
#0 22.73
#0 44.41 Could not solve for environment specs
#0 44.41 The following packages are incompatible
#0 44.41 └─ mlflow >1.29.0,<2  is installable with the potential options
#0 44.41    ├─ mlflow [1.30.0|2.2.1|...|2.4.1] would require
#0 44.41    │  └─ python >=3.8,<3.9.0a0 , which can be installed;
#0 44.41    ├─ mlflow [1.30.0|2.2.1|...|2.4.1] would require
#0 44.41    │  └─ python >=3.9,<3.10.0a0 , which can be installed;
#0 44.41    ├─ mlflow 1.30.0, which can be installed;
#0 44.41    └─ mlflow 1.30.0 would require
#0 44.41       └─ python >=3.7,<3.8.0a0 , which can be installed.
------
failed to solve: process "/bin/bash -c source activate morpheus     && mamba env update -n morpheus -f ./conda_env.yml" did not complete successfully: exit code: 1

mlflow conflicts

@mdemoret-nv
Copy link
Contributor

@pdmack I've merged branch-23.07 so this should have the updated version on mlflow

Copy link
Contributor

@mdemoret-nv mdemoret-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had some more thoughs.

docker/conda/environments/cuda11.8_examples.yml Outdated Show resolved Hide resolved
examples/digital_fingerprinting/production/conda_env.yml Outdated Show resolved Hide resolved
docker/conda/environments/cuda11.8_examples.yml Outdated Show resolved Hide resolved
@mdemoret-nv
Copy link
Contributor

@dagardner-nv Make sure to add the right keywords to close #1022 if this fixes that issue.

@dagardner-nv
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 0899b9e into nv-morpheus:branch-23.07 Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[BUG]: in morpheus/utils/file_utils.py, date_extractor() errors with access denied on s3
3 participants