fix: properly handle centerMarker removal logic #460
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add explicit centerMarker: true default to props - Fix center marker removal logic to respect centerMarker prop state - Resolves issue where center markers persisted when centerMarker=false
|
@Shaglock is attempting to deploy a commit to the Nuxt Team on Vercel. A member of the Team first needs to authorize it. |
Baltazore
approved these changes
Jun 1, 2025
harlan-zw
approved these changes
Jun 2, 2025
|
Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
This is a follow-up to my previous fix related to the centerMarkers #402 #454
❓ Type of change
📚 Description
This PR addresses another issue with the
centerMarkerprop in the Google Maps component:Fixed center marker removal bug: The marker removal logic was incorrectly protecting center markers from deletion regardless of the
centerMarkerprop state, causing center markers to persist even when disabledAdded explicit default value: Set
centerMarker: truein props defaults to make the component's behavior predictable and consistent with its implicit logic