fix(nuxt)!: remove public and assets alias to fix relative imports from other sources #32119

OrbisK · 2025-05-15T13:26:35Z

🔗 Linked issue

should fix #26164

📚 Description

This PR removes the explicit assets and public alias. This should fix for example any false positive resolved asset from node modules.

…er sources

bolt-new-by-stackblitz · 2025-05-15T13:26:38Z

Run & review this pull request in StackBlitz Codeflow.

pkg-pr-new · 2025-05-15T13:34:19Z

Open in StackBlitz

@nuxt/kit

npm i https://pkg.pr.new/@nuxt/kit@32119

nuxt

npm i https://pkg.pr.new/nuxt@32119

@nuxt/schema

npm i https://pkg.pr.new/@nuxt/schema@32119

@nuxt/rspack-builder

npm i https://pkg.pr.new/@nuxt/rspack-builder@32119

@nuxt/vite-builder

npm i https://pkg.pr.new/@nuxt/vite-builder@32119

@nuxt/webpack-builder

npm i https://pkg.pr.new/@nuxt/webpack-builder@32119

commit: b6dd68e

OrbisK · 2025-05-15T13:43:57Z

Looks like removing the aliases resulted in

  <img
    src="~/assets/logo.svg"
    class="h-20 mb-4"
  >

not working

codspeed-hq · 2025-05-15T13:44:26Z

CodSpeed Performance Report

Merging #32119 will not alter performance

_{Comparing OrbisK:fix/remove-assets-and-public-alias (b6dd68e) with main (8f8db53)}

Summary

✅ 10 untouched benchmarks

OrbisK · 2025-06-02T08:38:27Z

Looks like removing the aliases resulted in
  <img
    src="~/assets/logo.svg"
    class="h-20 mb-4"
  >
not working

Reason: vitejs/vite-plugin-vue#15

danielroe · 2025-06-02T09:15:11Z

We likely need to add a vite plugin of our own to add support for this until/unless it's fixed upstream. I think there should be no similar issue with the public alias, however.

OrbisK · 2025-06-02T12:30:38Z

I think there should be no similar issue with the public alias, however.

Do you mean keeping the public alias? I thought there might be some edge cases where a package or assets are built to @org/pkg/public, but maybe that's too much of an edge case.

danielroe · 2025-06-02T13:07:55Z

I mean, there is no problem with getting rid of it

packages/schema/src/config/vite.ts

packages/schema/src/config/webpack.ts

…-public-alias

coderabbitai · 2025-06-02T15:47:21Z

Warning

Rate limit exceeded

@danielroe has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 18 minutes and 10 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between c124b8c and b6dd68e.

📒 Files selected for processing (2)

packages/vite/src/vite.ts (2 hunks)
packages/webpack/src/presets/base.ts (2 hunks)

Walkthrough

The changes update the handling of directory aliases within configuration files and their associated tests. Specifically, the aliases for the "assets" and "public" directories have been removed from the common configuration resolver and the corresponding test snapshot. In contrast, new asynchronous resolvers for alias mappings based on the assets directory have been introduced in both the Vite and Webpack configuration schemas. These resolvers dynamically generate alias entries for the assets directory by resolving its path relative to the source directory, and merge any user-defined aliases. No changes were made to exported or public entity declarations.

✨ Finishing Touches

📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

fix!: remove public and assets alias to fix relative imports from oth…

c47f83e

…er sources

github-actions bot added 3.x bug labels May 15, 2025

test: update snapshot

434cfc0

OrbisK changed the title ~~fix(nuxt)!: remove public and assets alias to fix relative imports from oth…~~ fix(nuxt)!: remove public and assets alias to fix relative imports from other sources May 15, 2025

chore: remove unused code

ec345ff

chore: remove unused import

5d8d07f

OrbisK requested a review from danielroe May 17, 2025 11:55

wip: soft deprecate assets and public resolve alias types

acbcc1f

danielroe reviewed Jun 2, 2025

View reviewed changes

packages/schema/src/config/vite.ts Outdated Show resolved Hide resolved

danielroe reviewed Jun 2, 2025

View reviewed changes

packages/schema/src/config/vite.ts Outdated Show resolved Hide resolved

danielroe reviewed Jun 2, 2025

View reviewed changes

packages/schema/src/config/webpack.ts Outdated Show resolved Hide resolved

danielroe added 2 commits June 2, 2025 16:31

chore: remove public alias entirely

4d1c536

Merge remote-tracking branch 'origin/main' into fix/remove-assets-and…

635185b

…-public-alias

danielroe marked this pull request as ready for review June 2, 2025 15:44

autofix-ci bot and others added 3 commits June 2, 2025 15:47

[autofix.ci] apply automated fixes

c124b8c

refactor: move alias definitions into builders

03d7c6e

chore: remove unused import

b6dd68e

danielroe approved these changes Jun 2, 2025

View reviewed changes

danielroe merged commit f966a95 into nuxt:main Jun 2, 2025
46 checks passed

github-actions bot mentioned this pull request Jun 2, 2025

v4.0.0 #27716

Draft

OrbisK mentioned this pull request Jun 10, 2025

Allow ~/path as <img src="~/..."> with ~ alias vuejs/core#13460

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix(nuxt)!: remove public and assets alias to fix relative imports from other sources #32119

fix(nuxt)!: remove public and assets alias to fix relative imports from other sources #32119

OrbisK commented May 15, 2025 •

edited

Loading

Uh oh!

bolt-new-by-stackblitz bot commented May 15, 2025

Uh oh!

pkg-pr-new bot commented May 15, 2025 •

edited

Loading

Uh oh!

OrbisK commented May 15, 2025

Uh oh!

codspeed-hq bot commented May 15, 2025 •

edited

Loading

Uh oh!

OrbisK commented Jun 2, 2025

Uh oh!

danielroe commented Jun 2, 2025

Uh oh!

OrbisK commented Jun 2, 2025

Uh oh!

danielroe commented Jun 2, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

coderabbitai bot commented Jun 2, 2025 •

edited

Loading

Rate limit exceeded

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fix(nuxt)!: remove public and assets alias to fix relative imports from other sources #32119

fix(nuxt)!: remove public and assets alias to fix relative imports from other sources #32119

Conversation

OrbisK commented May 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Linked issue

📚 Description

Uh oh!

bolt-new-by-stackblitz bot commented May 15, 2025

Uh oh!

pkg-pr-new bot commented May 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

OrbisK commented May 15, 2025

Uh oh!

codspeed-hq bot commented May 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Performance Report

Merging #32119 will not alter performance

Summary

Uh oh!

OrbisK commented Jun 2, 2025

Uh oh!

danielroe commented Jun 2, 2025

Uh oh!

OrbisK commented Jun 2, 2025

Uh oh!

danielroe commented Jun 2, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

coderabbitai bot commented Jun 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Rate limit exceeded

Walkthrough

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

Uh oh!

Uh oh!

OrbisK commented May 15, 2025 •

edited

Loading

pkg-pr-new bot commented May 15, 2025 •

edited

Loading

codspeed-hq bot commented May 15, 2025 •

edited

Loading

coderabbitai bot commented Jun 2, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)