Skip to content

fix(typecheck): proxy overrides to loadNuxt #942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 7, 2025
Merged

Conversation

benjamincanac
Copy link
Member

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

@benjamincanac benjamincanac requested a review from danielroe as a code owner July 7, 2025 12:56
Copy link

pkg-pr-new bot commented Jul 7, 2025

nuxt-cli-playground

npm i https://pkg.pr.new/create-nuxt@942
npm i https://pkg.pr.new/nuxi@942
npm i https://pkg.pr.new/@nuxt/cli@942

commit: cf99825

Copy link
Contributor

github-actions bot commented Jul 7, 2025

Bundle Stats β€” create-nuxt size comparison

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
49 5.89 MB β†’ 5.89 MB (+51 B) +0.00%
Changeset
File Ξ” Size
home/runner/work/cli/cli/packages/nuxi/src/commands/typecheck.ts πŸ“ˆ +51 B (+2.48%) 2.01 kB β†’ 2.06 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
chunks/typecheck.mjs 2.01 kB β†’ 2.06 kB (+51 B) +2.48%

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
index.mjs 1.07 kB 0%
chunks/multipart-parser.mjs 5.11 kB 0%
chunks/multipart-parser2.mjs 4.58 kB 0%
chunks/add.mjs 6.89 kB 0%
chunks/analyze.mjs 3.35 kB 0%
chunks/build.mjs 2.04 kB 0%
chunks/cleanup.mjs 471 B 0%
chunks/dev-child.mjs 811 B 0%
chunks/dev.mjs 28.11 kB 0%
chunks/devtools.mjs 764 B 0%
chunks/generate.mjs 492 B 0%
chunks/info.mjs 4.43 kB 0%
chunks/index.mjs 274 B 0%
chunks/prepare.mjs 1.04 kB 0%
chunks/preview.mjs 3.58 kB 0%
chunks/test.mjs 1.16 kB 0%
chunks/upgrade.mjs 6.28 kB 0%
chunks/prompt.mjs 42.91 kB 0%
chunks/satisfies.mjs 116 B 0%
chunks/index2.mjs 197.8 kB 0%
chunks/jiti.mjs 305 B 0%
chunks/index3.mjs 71.97 kB 0%
chunks/add2.mjs 12.08 kB 0%
chunks/search.mjs 45.85 kB 0%
chunks/xdg-open.mjs 25.32 kB 0%
chunks/node.mjs 145.67 kB 0%
chunks/index4.mjs 1.23 kB 0%
chunks/index5.mjs 5.85 kB 0%
chunks/index6.mjs 6.24 kB 0%
chunks/index7.mjs 50.51 kB 0%
chunks/index8.mjs 898.9 kB 0%
shared/create-nuxt.By7dvbMP.mjs 964.56 kB 0%
shared/create-nuxt.D2Aw7BSD.mjs 792 B 0%
shared/create-nuxt.BSJ9ArJB.mjs 294 B 0%
shared/create-nuxt.B-pHMlgt.mjs 3.9 kB 0%
shared/create-nuxt.BSm0_9Hr.mjs 107 B 0%
shared/create-nuxt.CtbcNrIC.mjs 108.11 kB 0%
shared/create-nuxt.XMd2w0fR.mjs 18.91 kB 0%
shared/create-nuxt.BIva4cFj.mjs 1.17 MB 0%
shared/create-nuxt.Hu4KaZyJ.mjs 4.07 kB 0%
shared/create-nuxt.UxK15--B.mjs 836 B 0%
shared/create-nuxt.BNR94FNp.mjs 945 B 0%
shared/create-nuxt.ZZ01KPdK.mjs 15.27 kB 0%
shared/create-nuxt.BGUY8z1w.mjs 2.02 MB 0%
shared/create-nuxt.BjhZEm2-.mjs 1.75 kB 0%
shared/create-nuxt.CRFGonQc.mjs 4.06 kB 0%
shared/create-nuxt.Vk1IrVtB.mjs 26.96 kB 0%
shared/create-nuxt.4t9faemh.mjs 43.64 kB 0%

Copy link
Contributor

github-actions bot commented Jul 7, 2025

Bundle Stats β€” nuxt-cli size comparison

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
32 95.15 kB β†’ 95.2 kB (+51 B) +0.05%
Changeset
File Ξ” Size
home/runner/work/cli/cli/packages/nuxi/src/commands/typecheck.ts πŸ“ˆ +51 B (+2.48%) 2.01 kB β†’ 2.06 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
chunks/typecheck.mjs 2.01 kB β†’ 2.06 kB (+51 B) +2.48%

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
dev/index.mjs 0 B 0%
index.mjs 236 B 0%
chunks/index.mjs 14.79 kB 0%
chunks/analyze.mjs 3.35 kB 0%
chunks/cleanup.mjs 471 B 0%
chunks/dev-child.mjs 815 B 0%
chunks/dev.mjs 10.97 kB 0%
chunks/devtools.mjs 763 B 0%
chunks/generate.mjs 492 B 0%
chunks/build.mjs 2.04 kB 0%
chunks/info.mjs 4.44 kB 0%
chunks/index2.mjs 273 B 0%
chunks/add.mjs 10.17 kB 0%
chunks/search.mjs 2.96 kB 0%
chunks/prepare.mjs 1.04 kB 0%
chunks/preview.mjs 3.58 kB 0%
chunks/test.mjs 1.16 kB 0%
chunks/upgrade.mjs 6.28 kB 0%
chunks/init.mjs 9.85 kB 0%
chunks/add2.mjs 6.89 kB 0%
shared/cli.B9AmABr3.mjs 39 B 0%
shared/cli.Dz2be-Ai.mjs 792 B 0%
shared/cli.BEUGgaW4.mjs 294 B 0%
shared/cli.BSm0_9Hr.mjs 107 B 0%
shared/cli.At9IMXtr.mjs 1.23 kB 0%
shared/cli.pLQ0oPGc.mjs 836 B 0%
shared/cli.qKvs7FJ2.mjs 945 B 0%
shared/cli.P0cplz3M.mjs 78 B 0%
shared/cli.jA1DRKbi.mjs 1.04 kB 0%
shared/cli.Cxye68Cs.mjs 1.8 kB 0%
shared/cli.BpQCmRC-.mjs 5.55 kB 0%

Copy link

codspeed-hq bot commented Jul 7, 2025

CodSpeed Performance Report

Merging #942 will not alter performance

Comparing fix/typecheck-overrides (cf99825) with main (50b1fcf)

Summary

βœ… 2 untouched benchmarks

Copy link
Contributor

github-actions bot commented Jul 7, 2025

Bundle Stats β€” nuxi size comparison

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
58 5.47 MB β†’ 5.47 MB (+51 B) +0.00%
Changeset
File Ξ” Size
src/commands/typecheck.ts πŸ“ˆ +51 B (+2.48%) 2.01 kB β†’ 2.06 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
chunks/typecheck.mjs 2.01 kB β†’ 2.06 kB (+51 B) +2.48%

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
index.mjs 247 B 0%
dev/index.mjs 925 B 0%
chunks/add.mjs 6.89 kB 0%
chunks/analyze.mjs 3.35 kB 0%
chunks/build.mjs 2.04 kB 0%
chunks/cleanup.mjs 471 B 0%
chunks/dev-child.mjs 780 B 0%
chunks/dev.mjs 28.11 kB 0%
chunks/devtools.mjs 764 B 0%
chunks/generate.mjs 492 B 0%
chunks/info.mjs 4.43 kB 0%
chunks/init.mjs 665.87 kB 0%
chunks/index.mjs 274 B 0%
chunks/prepare.mjs 1.04 kB 0%
chunks/preview.mjs 3.58 kB 0%
chunks/test.mjs 1.16 kB 0%
chunks/upgrade.mjs 6.28 kB 0%
chunks/satisfies.mjs 116 B 0%
chunks/main.mjs 15.3 kB 0%
chunks/prompt.mjs 42.91 kB 0%
chunks/index2.mjs 197.8 kB 0%
chunks/jiti.mjs 305 B 0%
chunks/index3.mjs 71.97 kB 0%
chunks/multipart-parser.mjs 5.11 kB 0%
chunks/add2.mjs 12.08 kB 0%
chunks/search.mjs 45.85 kB 0%
chunks/xdg-open.mjs 25.32 kB 0%
chunks/node.mjs 145.67 kB 0%
chunks/index4.mjs 1.23 kB 0%
chunks/index5.mjs 5.85 kB 0%
chunks/multipart-parser2.mjs 4.58 kB 0%
chunks/index6.mjs 898.9 kB 0%
shared/nuxi.bYOTTMda.mjs 19.31 kB 0%
shared/nuxi.Dh2ZdpAd.mjs 57.22 kB 0%
shared/nuxi.CTyTlDmo.mjs 18.91 kB 0%
shared/nuxi.DzMZtGWH.mjs 792 B 0%
shared/nuxi.BtDT0y5R.mjs 294 B 0%
shared/nuxi.Cm5apyPX.mjs 2.57 kB 0%
shared/nuxi.Db0skjkt.mjs 915.23 kB 0%
shared/nuxi.D2_bzAv0.mjs 1.54 kB 0%
shared/nuxi.DtQ0anGB.mjs 4.07 kB 0%
shared/nuxi.BSm0_9Hr.mjs 107 B 0%
shared/nuxi.DMyZmNH9.mjs 836 B 0%
shared/nuxi.BiWTNJI4.mjs 945 B 0%
shared/nuxi.CjPgFUSq.mjs 15.27 kB 0%
shared/nuxi.ChutbOY_.mjs 25.34 kB 0%
shared/nuxi.D5KtpA0t.mjs 984 B 0%
shared/nuxi._Un-q2ql.mjs 2.02 MB 0%
shared/nuxi.BjhZEm2-.mjs 1.75 kB 0%
shared/nuxi.BEgIcxrx.mjs 4.06 kB 0%
shared/nuxi.DU9QXUOf.mjs 26.96 kB 0%
shared/nuxi.BzZJv2UC.mjs 123.67 kB 0%
shared/nuxi.QWnQy_ku.mjs 5.75 kB 0%
shared/nuxi.CbyJ5osS.mjs 13.45 kB 0%
shared/nuxi.BLb4POFS.mjs 42.47 kB 0%
shared/nuxi.Do0aYBCO.mjs 5.46 kB 0%
shared/nuxi.4t9faemh.mjs 43.64 kB 0%

Copy link
Member

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you ❀

@danielroe danielroe merged commit 76dd3eb into main Jul 7, 2025
14 checks passed
@danielroe danielroe deleted the fix/typecheck-overrides branch July 7, 2025 14:48
@github-actions github-actions bot mentioned this pull request Jul 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants