Skip to content

feat(module): add multiple modules at once #584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 18, 2024

Conversation

BobbieGoede
Copy link
Member

@BobbieGoede BobbieGoede commented Dec 6, 2024

๐Ÿ”— Linked issue

โ“ Type of change

  • ๐Ÿ“– Documentation (updates to the documentation or readme)
  • ๐Ÿž Bug fix (a non-breaking change that fixes an issue)
  • ๐Ÿ‘Œ Enhancement (improving an existing functionality)
  • โœจ New feature (a non-breaking change that adds functionality)
  • ๐Ÿงน Chore (updates to the build process or auxiliary tools and libraries)
  • โš ๏ธ Breaking change (fix or feature that would cause existing functionality to change)

๐Ÿ“š Description

Resolves #65
Closes #233

This is an updated version of #233 (credited in commit).

The original implementation triggered a dependency installation for each module, I have made changes so that only one single installation is triggered.

BobbieGoede and others added 2 commits December 6, 2024 13:59
Co-authored-by: rohrig <45824492+rohrig@users.noreply.github.com>
@BobbieGoede BobbieGoede self-assigned this Dec 6, 2024
@BobbieGoede BobbieGoede changed the title Feat/multiple modules feat: multiple modules Dec 6, 2024
@BobbieGoede BobbieGoede changed the title feat: multiple modules feat: add multiple modules at once Dec 6, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 59 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@0245c91). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/commands/module/add.ts 0.00% 59 Missing โš ๏ธ
Additional details and impacted files
@@          Coverage Diff           @@
##             main    #584   +/-   ##
======================================
  Coverage        ?   1.31%           
======================================
  Files           ?      44           
  Lines           ?    2882           
  Branches        ?      44           
======================================
  Hits            ?      38           
  Misses          ?    2803           
  Partials        ?      41           

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.

@danielroe danielroe changed the title feat: add multiple modules at once feat(add): add multiple modules at once Dec 7, 2024
@danielroe danielroe changed the title feat(add): add multiple modules at once feat(module): add multiple modules at once Dec 18, 2024
@danielroe danielroe merged commit f76679d into nuxt:main Dec 18, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for adding multiple module at once
3 participants