Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: better scrollbars #673

Merged
merged 3 commits into from
Nov 26, 2022
Merged

feat: better scrollbars #673

merged 3 commits into from
Nov 26, 2022

Conversation

bdrtsky
Copy link
Contributor

@bdrtsky bdrtsky commented Nov 17, 2022

closes #642

@vercel
Copy link

vercel bot commented Nov 17, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
docus ✅ Ready (Inspect) Visit Preview Nov 21, 2022 at 9:16AM (UTC)

@Tahul
Copy link
Contributor

Tahul commented Nov 17, 2022

@atinux ; wdyt?

I personally prefer preserving native scrollbars but I guess that's up to preference.

Copy link
Contributor

atinux commented Nov 17, 2022

@Tahul
Copy link
Contributor

Tahul commented Nov 17, 2022

I would only activate it for Windows like Volta is doing:

😍, that's perfect, wdyt @bdrtsky ?

@bdrtsky
Copy link
Contributor Author

bdrtsky commented Nov 18, 2022

Ok, but I have customized Volta scrollbar on Mac as well 😅

@atinux
Copy link
Contributor

atinux commented Nov 18, 2022

Ok, but I have customized Volta scrollbar on Mac as well 😅

I don't, how that's possible? Maybe the client plugin not detecting well your browser?

Does it match in your console navigator && navigator.userAgent && navigator.userAgent.match(/Win[a-z0-9]*;/) ?

@bdrtsky
Copy link
Contributor Author

bdrtsky commented Nov 18, 2022

MacOS, Brave browser 🤷‍♂️

Screenshot 2022-11-18 at 17 07 30

Screenshot 2022-11-18 at 17 06 54

Screenshot 2022-11-18 at 17 06 03

@atinux
Copy link
Contributor

atinux commented Nov 18, 2022

I see, cc @benjamincanac to update the regexp on Volta too

But why Brave gives a Windows user agent 😅

Copy link
Collaborator

This is really weird indeed 🤯

@Tahul Tahul merged commit 76a0ddc into dev Nov 26, 2022
@Tahul Tahul deleted the feat/better-scrollbars branch November 26, 2022 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better scrollbar for Windows
4 participants