Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: multi slot levels in components #434

Closed
Tahul opened this issue Jun 15, 2021 · 0 comments
Closed

feat: multi slot levels in components #434

Tahul opened this issue Jun 15, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@Tahul
Copy link
Contributor

Tahul commented Jun 15, 2021

Reporting conclusions from this PR:

#432

Atinux:
I removed the usage of the HeroTemplate wrapper, it seems that multi slots levels does not work (not really a surprise), cc @farnabaz so you know we have this issue, but we can investigate after this week :)
Farnabaz:
About the multi level slot, this is expected, since <Markdown> looks lots in parent component.
There is a node props in <Markdown> that users can pass slots directory to it
OR
we can walk through parents and find the right slot

From my perspective, using Node props from Markdown should be great, but maybe this needs to be documented.

I will document the API part once we are done with NuxtJS.org of course.

@Tahul Tahul added the enhancement New feature or request label Jun 15, 2021
@Tahul Tahul closed this as completed Jun 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant