Skip to content

Conversation

@LouisHaftmann
Copy link
Contributor

fixes #423

@netlify
Copy link

netlify bot commented Oct 26, 2023

Deploy Preview for friendly-lamington-fb5690 ready!

Name Link
🔨 Latest commit 400e142
🔍 Latest deploy log https://app.netlify.com/sites/friendly-lamington-fb5690/deploys/6597d8296ca01400089fc738
😎 Deploy Preview https://deploy-preview-478--friendly-lamington-fb5690.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! ❤️

However, #app is the correct location to import Plugin from, so I will need to investigate why it's being stripped from the build output types.

@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (68b2832) 83.36% compared to head (03ebce7) 83.36%.
Report is 22 commits behind head on main.

❗ Current head 03ebce7 differs from pull request most recent head 400e142. Consider uploading reports for the commit 400e142 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #478   +/-   ##
=======================================
  Coverage   83.36%   83.36%           
=======================================
  Files           9        9           
  Lines         493      493           
  Branches       30       30           
=======================================
  Hits          411      411           
  Misses         82       82           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danielroe danielroe merged commit 0b7ada6 into nuxt-modules:main Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: Component types become any after router integration

2 participants