Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: customRoutes clarification #3036

Merged
merged 1 commit into from
Jul 21, 2024
Merged

docs: customRoutes clarification #3036

merged 1 commit into from
Jul 21, 2024

Conversation

BobbieGoede
Copy link
Collaborator

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Resolves #3029

Further clarifies that the two methods of configuring custom routes is mutually exclusive.

📝 Checklist

  • I have linked an issue or discussion.
  • I have added tests (if possible).
  • I have updated the documentation accordingly.

@BobbieGoede BobbieGoede requested a review from kazupon July 21, 2024 14:17
@BobbieGoede BobbieGoede self-assigned this Jul 21, 2024
kazupon
kazupon approved these changes Jul 21, 2024
View reviewed changes
Copy link
Collaborator

@kazupon kazupon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kazupon kazupon merged commit cb13b69 into nuxt-modules:main Jul 21, 2024
7 checks passed
@MickL
Copy link
Contributor

MickL commented Jul 21, 2024

👍🏻👍🏻👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kazupon kazupon kazupon approved these changes

Assignees

@BobbieGoede BobbieGoede

Labels
docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Custom Route Paths in nuxt.config dont work together with compiler macro defineI18nRoute
3 participants
@BobbieGoede @MickL @kazupon