Make nuScenes compatible to Python3.5/Python3.6 #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
venice-erin
commented
Mar 15, 2019
venice-erin
commented
- Removed typing that were only suitable to only Python3.6 onwards
- Removed the future import
- Tutorial and unittests ran well
- Also includes minor cleanups to reduce PyCharm warnings
- WIP because will wait for other PRs to be merged in to again check compatibility.
|
I endorse py 3.5/3.6 compatibility! Would simplify my workflow. |
oscar-nutonomy
approved these changes
Mar 15, 2019
sourabh-nutonomy
approved these changes
Mar 15, 2019
Alex-nutonomy
changed the title
Alex-nutonomy
approved these changes
Mar 15, 2019
Alex-nutonomy
pushed a commit
that referenced
this pull request
Mar 25, 2019
* Added setup.py for pip installation * Added speedup to query many points with single function call in map mask * Added missing methods for improved map mask * Changes for v0.2 * Updated tutorial path * Changed logic s.t. map table points to logs, not 1 to 1 * Fix indexing bug * Reset paths to default * Removed print statement from setup.py * Fixed a bug for large map files * Not excluding any logs from map rendering * Fixed bug with missing "self" keyword in create_splits_logs(nusc), added dataroot parameter * Address bug for classes without attributes * Fixed misspelled motorcycle * Added missing keyword self * Added checks for nan values * Removed teaser splits as they is not compatible with the new logs * Added (preliminary) splits for v0.2 * Workaround to allow evaluating a subset of the data * Splits hardcoded in create_splits_logs * Fix bugs if a results file has zero TPs * Simpler MapMask (#31) * deleted distance_mask, binary_mask. Created dilate_mask(). * cleanup docstring * Added missing Dict import (#35) * Typing fix (#36) * Added missing Dict import * Fixed typing to be compatible where future annotations package cannot be loaded * Updated code to new folder structure (#37) * Devkit now accepts versions 0.3, 0.4 and 1.0 * Fix TPs analog to commit 94544b5 (#41) * Fix yaw_diff calculation (#46) * Added unittest to catch previous error in yaw_diff * Updated dataset to v0.4, updated train/val/test splits * Added assertion * Cleaned up map API. * Evaluation Fixes (#51) * Correct recall edge case * Apply distance filtering to xy only * Return max error if recall is too low * Added dataset version as command line argument to nuscenes_eval.py * Function to get scenes in each split, script to check dataset completeness * Added command line arguments to launch scripts * Hotfix for call to create_splits_logs * Structure re-org towards more tests. (#52) - Moves files around to enable easier inject of tests. - Enables running unit-tests per usual python -m unittest - Requires env. variable $NUSCENES for test. - Added trivial unit-tests for NuScenes & NuScenesEval. Currently uses v0.2. We should switch to mini when data is ready. - Moved detection eval code to eval/detection to future-proof for next task. This PR is only the first step. The next PR will break out the detection eval code to enable testing. * Updated dataset splits to v1.0 * Updated version to 1.0 and database folder to /data/sets/nuscenes * Added explanation that visibility token may be empty * Style update (#59) * Changed format of data_classes.py and avoided default parameters in RadarPointCloud * Typing and line breaks in long method signatures * Reset dynprop_states to previous settings * Spacing and line breaks * Spacing * Break circular import dependencies * More flexible setup.py * Cleanup setup.py * Updated radar comments * fix setup to include root folder * Backporting bugfix from 873b30b until eval pr is merged * new pip package * Workaround to allow version string to include the split, e.g. v1.0-trainval * Mini splits and modified split logic (#63) * Added mini splits and updated overall logic, note: changed method signatures * Added an assertion * Docstrings * Fixed typo * Updated eval code to new splits function * Eval refactor step2 (#53) * reorganized repo to more allow for easier injection of tests. Moved detection eval code to eval/detection subfolder * Added verify and test instructions to main README * Added more thorough regression type test. This seem to have triggered an error in the evaluation code * Standardized dataroot to /data/sets/nuscenes * Fixed random seed. Passes unit-tests now * Added data-classes for the EvalBoxes. Cleaned up loading. Same results verified on test_delta() * Updated all tests to use the EvalBox data class. All tests passing now. * Changes to calculating distance from ego_vehicle (#57) * Changed result format to accept at most one attribute (#60) * Replaced attribute_scores by a single attribute_name * v0.2 CI preparation. (#65) * updated to 1.0-mini split for all tests. Skipped those that require DB * Misc Reorg (#68) * reorganize geometry code * add shortcuts to common classes * move quaternion yaw back * change default nuscenes to mini * Integrate mini_split into continuous integration (#71) * Enabled v1.0-mini to be used in CI for unit-tests. * Updated detection metrics code (#66) * Reorganized eval code to more allow for easier injection of tests. * Make nuScenes compatible to Python3.5/Python3.6 (#70) * Removed python 3.6 and 3.7 only features to make compatible with 3.5 * nuscenes-devkit pip package v0.3.4 * Added num_lidar_points and num_radar_points to schema * Added instructions to include lidar and radar points * update create_splits_logs to new database versions (#74) * Some unittests for algo.py and util.py (#76) * Added unittest for utils.py and algo.py * Repeat unit tests for Python 3.6, 3.7 + bug fix for false negative (#77) * Fixed false negative issue. Added support for 3.6 and 3.7. * Create a configuration factory (#78) * create a configuration factory * add unittests * fix the unittests * added token field to Box class (#79) * added token field to Box class * fixed line-break * Update README installation instructions. (#75) * Cleaned up README. Changed to support for python 3.6 and 3.7. * added change log message for release * * Moved continuous integration and Docker dependencies to 'setup' folder. (#80) * Updated readme files (#81) * Added setup/instrucions.md, updated Debris class definition, tuned main README * update setup.py to new repo structure * Update tutorial.ipynb * Simple Unittests for AP calculation (#82) * Clean up old unit tests and added tests for AP calculation * Revert setup changes to get CI working (#84) * Revert "* Moved continuous integration and Docker dependencies to 'setup' folder. (#80)" This reverts commit fa55433. * revert setup.py changes * Bikerack filtering (#83) * spellcheck * add points_in_box() method to check whether points are inside the box * test points_in_box() method * perform bike rack filtering * docstring for filter_eval_boxes * added unittests for filter_eval_boxes() * update comment * fix docstring * can't use Box type because of a circular import. So switched to 'Box' * can't use Box type because of a circular import. So switched to 'Box' * change threshold after bikerack filtering * get max_dist from eval_detection_configs * Update eval renderers (#85) * Updated renderers for detection results. * Fixed bugs in detection evaluation. * Added color options for render_egoposes_on_map (#86) * add color option for render maps * Summary AP plot update (#87) * updated the plots * better legend text alignment * updated legend positions and pretty names for attributes and TP metrics * Tex table (#91) * added reder tex table * cleaned up tex render method * minor changes * add credits * misc cleanup * Instruction updates and misc (#89) * Set default version for export egoposes, better outputs * Added v1.0 to legal datasets * Corrected visibility level * Set face color to black, better status messages * Updated face color * Set set to trainval in misc scripts * Bugfix to preserver black bg color * Made close_dist a parameter * Merged truck classes in the instructions * Removed train from instructions * Merged police officers into single class * Reset changes to tutorial * Updated path to requirements.txt * Removed v1.0 which was used for setup purposes * Cleanup * Fix visibility levels in instructions * Also print empty categories * Fixed bug * Reversed previous changes * Updated schema comments for map * Reverted previous changes * misc cleanup * next pip package * added unittests for TP metrics * Readme update (#93) * OVerhauled eval detection page * Overhauled main readme * Removed deprecated links * Rewording * Addressed review comments * fixed the visualize sample, need to test it * added comments to unit tests * [WIP] Jupyter notebook tutorial (#90) * Updated tutorial * Unittests for true positive error metrics calculation (#92) * added unittests for TP metrics * fixed visualize sample * added comments to unit tests * added option to save sample rendering to disk * added back showing plot if savepath is not given * Update README.md Clarifications * Update schema.md added an example for subcategories * update dates * cleanup imports, fix readme typos, cleaner scripts * cleanup evaluate * fix splits * update unittest to split logic * update test delta
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.