fix(internal): phpstan errors

Author: jankal

composer.json

@@ -16,7 +16,8 @@
   },
   "require-dev": {
     "phpstan/phpstan": "^2.1.2",
-    "friendsofphp/php-cs-fixer": "^3.66"
+    "friendsofphp/php-cs-fixer": "^3.66",
+    "shopwarelabs/phpstan-shopware": "^0.1.8"
   },
   "scripts": {
     "phpstan": "phpstan analyse --memory-limit=2G",

phpstan.neon

@@ -4,3 +4,6 @@ parameters:
         - src
     scanDirectories:
         - ../../../vendor
+
+includes:
+    - vendor/shopwarelabs/phpstan-shopware/rules.neon

src/Action/RefreshAction.php

@@ -20,13 +20,13 @@ public function __construct(
     ) {
     }
 
-    public function execute(bool $async = true): void
+    public function execute(Context $context, bool $async = true): void
     {
         $now = new \DateTime();
         $this->loadIndexAction->execute();
 
         $this->cleanupPluginsTask->execute(
-            Context::createDefaultContext(),
+            $context,
             $now,
         );
 

src/Command/RefreshCommand.php

@@ -5,6 +5,7 @@
 namespace NuonicPluginInstaller\Command;
 
 use NuonicPluginInstaller\Action\RefreshAction;
+use Shopware\Core\Framework\Context;
 use Symfony\Component\Console\Attribute\AsCommand;
 use Symfony\Component\Console\Command\Command;
 use Symfony\Component\Console\Input\InputInterface;
@@ -21,7 +22,7 @@ public function __construct(
 
     protected function execute(InputInterface $input, OutputInterface $output): int
     {
-        $this->refreshAction->execute(false);
+        $this->refreshAction->execute(Context::createCLIContext(), false);
 
         return Command::SUCCESS;
     }

src/Controller/InstallController.php

@@ -53,7 +53,7 @@ public function execute(Request $request, Context $context): Response
             $this->malformedRequestError();
         }
 
-        /** @var AvailableOpensourcePluginEntity $plugin */
+        /** @var AvailableOpensourcePluginEntity|null $plugin */
         $plugin = $this->openSourcePluginRepository->search(new Criteria([$requestData['openSourcePluginId']]), $context)
             ->first();
 

src/Core/Framework/Plugin/AvailableOpensourcePlugin/AvailableOpensourcePluginDefinition.php

@@ -43,8 +43,8 @@ protected function defineFields(): FieldCollection
     {
         return new FieldCollection([
             (new IdField('id', 'id'))->addFlags(new Required(), new PrimaryKey()),
-            (new TranslatedField('name', 'name'))->addFlags(new Required()),
-            (new TranslatedField('description', 'description'))->addFlags(new Required()),
+            (new TranslatedField('name'))->addFlags(new Required()),
+            (new TranslatedField('description'))->addFlags(new Required()),
             (new StringField('package_name', 'packageName'))->addFlags(new Required()),
             (new StringField('manufacturer', 'manufacturer'))->addFlags(new Required()),
             (new StringField('manufacturer_link', 'manufacturerLink'))->addFlags(new Required()),

src/Core/Framework/Plugin/AvailableOpensourcePlugin/AvailableOpensourcePluginEntity.php

@@ -4,6 +4,7 @@
 
 namespace NuonicPluginInstaller\Core\Framework\Plugin\AvailableOpensourcePlugin;
 
+use Shopware\Core\Content\Media\MediaEntity;
 use Shopware\Core\Framework\DataAbstractionLayer\Entity;
 use Shopware\Core\Framework\DataAbstractionLayer\EntityIdTrait;
 use Shopware\Core\Framework\Plugin\PluginEntity;
@@ -24,6 +25,7 @@ class AvailableOpensourcePluginEntity extends Entity
 
     protected ?string $icon;
 
+    /** @var MediaEntity[]|null */
     protected ?array $images;
 
     protected string $license;
@@ -100,11 +102,18 @@ public function setIcon(?string $icon): void
         $this->icon = $icon;
     }
 
+    /**
+     * @return MediaEntity[]|null
+     */
     public function getImages(): ?array
     {
         return $this->images;
     }
 
+    /**
+     * @param MediaEntity[]|null $images
+     * @return void
+     */
     public function setImages(?array $images): void
     {
         $this->images = $images;

src/NuonicPluginInstaller.php

@@ -53,15 +53,11 @@ public function uninstall(UninstallContext $uninstallContext): void
 
     public function postInstall(InstallContext $installContext): void
     {
-        if ($action = $this->container->get(RefreshAction::class)) {
-            $action->execute();
-        }
+        $this->container->get(RefreshAction::class)->execute($installContext->getContext());
     }
 
     public function postUpdate(UpdateContext $updateContext): void
     {
-        if ($action = $this->container->get(RefreshAction::class)) {
-            $action->execute();
-        }
+        $this->container->get(RefreshAction::class)->execute($updateContext->getContext());
     }
 }

src/ScheduledTask/LoadIndex/LoadIndexScheduledTask.php

@@ -15,6 +15,6 @@ public static function getTaskName(): string
 
     public static function getDefaultInterval(): int
     {
-        return 1_800;
+        return 3_600; // 1 hour
     }
 }

src/ScheduledTask/LoadPluginInfo/LoadPluginInfoScheduledTask.php

@@ -15,6 +15,6 @@ public static function getTaskName(): string
 
     public static function getDefaultInterval(): int
     {
-        return 1_800;
+        return 3_600; // 1 hour
     }
 }