Lumen compatability #247
Lumen compatability #247
Conversation
andrewnclark
force-pushed
the
lumen-compatability
branch
from
b184a29 to
fff245e
Compare
| $this->publishes([ | ||
| __DIR__ . '/../../../../stubs/laravel.php' => $this->app->configPath('insights.php'), | ||
| ], 'config'); | ||
| if (strpos($this->app->version(), 'Lumen') !== 0) { |
There was a problem hiding this comment.
Did you double check that this code is working as expected in a normal lararel application?
There was a problem hiding this comment.
There is a method called version in Laravel, and that one just returns a version number in Laravel.
However I think a "better" way to do this is to check $this->app implements Illuminate\Contracts\Foundation\Application, because then we know it's a Laravel project.
There was a problem hiding this comment.
Ah I did write the instanceof version first and changed it, I'll switch back to... always trust your initial thoughts!
andrewnclark
force-pushed
the
lumen-compatability
branch
from
4f20c54 to
2f3cfee
Compare
andrewnclark
force-pushed
the
lumen-compatability
branch
from
2f3cfee to
842ea54
Compare
|
Made the requested changes and rebased onto the current version of master. I can also confirm that I have tested it with a Laravel installation and the service provider still works as expected. |
Following the conversion in #235 this PR updates the Laravel service provider to detect when it is being used in a Lumen application and avoid calling
$this->publishesas the publish command is not available.We could potentially make a separate Lumen service provider if preferred.
With the above changes in mind, I also updated the documentation to provide steps for install phpinsights in a Lumen app.