On testing exceptions Collision should not render exceptions

[nunomaduro]

In Laravel, we may want to test if an exception is throw correctly. Given the following routes/web.php:

Route::get('/', function () {
    throw new Exception("This is an exception");
});

And the following test:

$response = $this->get('/');
$response->assertStatus(500);

Our application exception handler should not render an exception.

[bobbybouwmann]

I think you need some kind of middleware to that, or tweak your exception handler. Not sure if this should be package specific. Just my two cents!

If I have some time left today I will look into this a bit more ;)

[nunomaduro]

@bobbybouwmann Thanks for those two cents! I may dive into this issue this weekend 😎

[san4io]

I think it also shouldn't react in tests to default exceptions like: Validation, Unauthorized, Unauthenticated.

I'm writing test and expect to get 401, of course it passes, but dunno if your listener should catch such exceptions, or maybe it would be great to have ignoredExceptions configuration:

$response = $this->json('GET', '/api/v1/claims');

$response->assertStatus(401);

Illuminate\Auth\AuthenticationException : Unauthenticated.

  at /var/www/vendor/laravel/framework/src/Illuminate/Auth/Middleware/Authenticate.php: 66
  62:                 return $this->auth->shouldUse($guard);
  63:             }
  64:         }
  65: 
  66:         throw new AuthenticationException('Unauthenticated.', $guards);
  67:     }
  68: }
  69: 

All in all, awesome package. :)

[nunomaduro]

@san4io Thanks for the feedback and for your suggestion!

I will definitely find something this issue. I just didn't have 5 mins minutes to look into to it. I may check tomorrow!

[nunomaduro]

@bobbybouwmann @san4io I was thinking about using the method $this->shouldReport($e) to understand if collision should render the exception on testing environment.

Like committed on this hot-fix branch: ae9f452

Like that, all Laravel Internal exceptions are ignored on testing env by Collision. What do you guys think? 😊

Other option, is just render an exception via Collision when the status code is 500.

[nunomaduro]

The version v1.1.6 should have this problem fixed.

[bobbybouwmann]

This looks pretty good to me! Great job on this :D