Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggestion: Wrong actual type used with DictionaryContainsKeyConstraint. #247

Open
ChrisMaddock opened this issue Jun 7, 2020 · 0 comments
Open

Suggestion: Wrong actual type used with DictionaryContainsKeyConstraint. #247

ChrisMaddock opened this issue Jun 7, 2020 · 0 comments
Labels
improvement

Comments

@ChrisMaddock
Copy link
Member

DictionaryContainsKeyConstraint is not type-safe, and it would be useful to have an analyser to detect incorrect usage of this - similar to the current ContainsConstraintWrongActualTypeAnalyzer.

I just hit this problem working on the NUnit Engine - as I was converting Dictionaries to HashSets. It would have been nice to have a compile-time warning about my problem, rather than having to wait for the test run to complete. 🙂
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mikkelbu @ChrisMaddock