From 4a46b74bbaf8a11a1c22c3f046f5fb32d7a09809 Mon Sep 17 00:00:00 2001
From: MarcNumworks <marc.coudriau@numworks.com>
Date: Tue, 2 Apr 2024 14:28:27 +0200
Subject: [PATCH] Revert "[build/screenshot] Add --skip-idle flag to
 take_for_each_step.py"

This reverts commit 46dc4f3a846f38211cdca6b75506b89eb7230cb6.
---
 build/screenshots/helper.py             | 9 +++------
 build/screenshots/take_for_each_step.py | 9 ++-------
 2 files changed, 5 insertions(+), 13 deletions(-)

diff --git a/build/screenshots/helper.py b/build/screenshots/helper.py
index 615709ea133..26261fd8a86 100644
--- a/build/screenshots/helper.py
+++ b/build/screenshots/helper.py
@@ -46,9 +46,7 @@ def print_error(stderr, exit=True):
             sys.exit(1)
 
 
-def generate_all_screenshots(
-    state_file, executable, folder, skip_idle, exit_if_error=True
-):
+def generate_all_screenshots(state_file, executable, folder, exit_if_error=True):
     print("Generating all screenshots of", state_file)
     clean_or_create_folder(folder)
     p = Popen(
@@ -56,7 +54,6 @@ def generate_all_screenshots(
         + executable
         + " --headless --load-state-file "
         + state_file
-        + (" --skip-idle-screenshots " if skip_idle else "")
         + " --take-all-screenshots "
         + folder,
         shell=True,
@@ -99,11 +96,11 @@ def folder_images(folder):
 
 
 def generate_all_screenshots_and_create_gif(
-    state_file, executable, folder, skip_idle=False, exit_if_error=True
+    state_file, executable, folder, exit_if_error=True
 ):
     clean_or_create_folder(folder)
     list_images = generate_all_screenshots(
-        state_file, executable, folder_images(folder), skip_idle, exit_if_error
+        state_file, executable, folder_images(folder), exit_if_error
     )
     create_gif(list_images, folder)
     return list_images
diff --git a/build/screenshots/take_for_each_step.py b/build/screenshots/take_for_each_step.py
index 311e1abb620..13ac9f8db1b 100644
--- a/build/screenshots/take_for_each_step.py
+++ b/build/screenshots/take_for_each_step.py
@@ -18,19 +18,14 @@
     help="state file (with extension .nws)",
 )
 parser.add_argument(
-    "-o", "--output-folder", default="screenshots_each_step", help="output folder"
-)
-parser.add_argument(
-    "--skip-idle",
-    action="store_true",
-    help="skip screenshots associated with idle events",
+    "-o", "--output_folder", default="screenshots_each_step", help="output folder"
 )
 
 
 def main():
     args = parser.parse_args()
     helper.generate_all_screenshots_and_create_gif(
-        args.state_file, args.executable, args.output_folder, args.skip_idle, False
+        args.state_file, args.executable, args.output_folder, False
     )