Fix dynamic version specification. #477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jarrodmillman
approved these changes
Jul 3, 2023
|
If we're compiling the toml anyway, why not inject a static version parsed from the code? |
|
We can make a follow-up PR if we decide to inject a static version parsed from the code. |
|
In several projects I've started using setuptools_scm with good |
|
... results. But you need the git history so maybe not a good choice here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed a small bug coming from #474. In order to use the dynamic version, you have to specify where it is coming from otherwise it installs as
numpydoc-0.0.0. I added the required logic to thetools/pyproject.toml.infile and ran the script to update the file.Before change:
Successfully installed numpydoc-0.0.0After change:
Successfully installed numpydoc-1.6.0rc1.dev0