Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't upload to PyPI when README has badges #577

Closed
jarrodmillman opened this issue Jul 24, 2024 · 2 comments · Fixed by #578
Closed

Can't upload to PyPI when README has badges #577

jarrodmillman opened this issue Jul 24, 2024 · 2 comments · Fixed by #578

Comments

@jarrodmillman
Copy link
Member

jarrodmillman commented Jul 24, 2024

The upload to PyPI for 1.8.0rc0 failed (see) with this error:

Run pypa/gh-action-pypi-publish@release/v1
/usr/bin/docker run --name b88e81c48f28efaac475b9ba2058224e06e48_9d7a1d --label 5b88e8 --workdir /github/workspace --rm -e "pythonLocation" -e "PKG_CONFIG_PATH" -e "Python_ROOT_DIR" -e "Python2_ROOT_DIR" -e "Python3_ROOT_DIR" -e "LD_LIBRARY_PATH" -e "INPUT_USER" -e "INPUT_PASSWORD" -e "INPUT_REPOSITORY-URL" -e "INPUT_REPOSITORY_URL" -e "INPUT_PACKAGES-DIR" -e "INPUT_PACKAGES_DIR" -e "INPUT_VERIFY-METADATA" -e "INPUT_VERIFY_METADATA" -e "INPUT_SKIP-EXISTING" -e "INPUT_SKIP_EXISTING" -e "INPUT_VERBOSE" -e "INPUT_PRINT-HASH" -e "INPUT_PRINT_HASH" -e "HOME" -e "GITHUB_JOB" -e "GITHUB_REF" -e "GITHUB_SHA" -e "GITHUB_REPOSITORY" -e "GITHUB_REPOSITORY_OWNER" -e "GITHUB_REPOSITORY_OWNER_ID" -e "GITHUB_RUN_ID" -e "GITHUB_RUN_NUMBER" -e "GITHUB_RETENTION_DAYS" -e "GITHUB_RUN_ATTEMPT" -e "GITHUB_REPOSITORY_ID" -e "GITHUB_ACTOR_ID" -e "GITHUB_ACTOR" -e "GITHUB_TRIGGERING_ACTOR" -e "GITHUB_WORKFLOW" -e "GITHUB_HEAD_REF" -e "GITHUB_BASE_REF" -e "GITHUB_EVENT_NAME" -e "GITHUB_SERVER_URL" -e "GITHUB_API_URL" -e "GITHUB_GRAPHQL_URL" -e "GITHUB_REF_NAME" -e "GITHUB_REF_PROTECTED" -e "GITHUB_REF_TYPE" -e "GITHUB_WORKFLOW_REF" -e "GITHUB_WORKFLOW_SHA" -e "GITHUB_WORKSPACE" -e "GITHUB_ACTION" -e "GITHUB_EVENT_PATH" -e "GITHUB_ACTION_REPOSITORY" -e "GITHUB_ACTION_REF" -e "GITHUB_PATH" -e "GITHUB_ENV" -e "GITHUB_STEP_SUMMARY" -e "GITHUB_STATE" -e "GITHUB_OUTPUT" -e "RUNNER_OS" -e "RUNNER_ARCH" -e "RUNNER_NAME" -e "RUNNER_ENVIRONMENT" -e "RUNNER_TOOL_CACHE" -e "RUNNER_TEMP" -e "RUNNER_WORKSPACE" -e "ACTIONS_RUNTIME_URL" -e "ACTIONS_RUNTIME_TOKEN" -e "ACTIONS_CACHE_URL" -e "ACTIONS_ID_TOKEN_REQUEST_URL" -e "ACTIONS_ID_TOKEN_REQUEST_TOKEN" -e "ACTIONS_RESULTS_URL" -e GITHUB_ACTIONS=true -e CI=true -v "/var/run/docker.sock":"/var/run/docker.sock" -v "/home/runner/work/_temp/_github_home":"/github/home" -v "/home/runner/work/_temp/_github_workflow":"/github/workflow" -v "/home/runner/work/_temp/_runner_file_commands":"/github/file_commands" -v "/home/runner/work/numpydoc/numpydoc":"/github/workspace" 5b88e8:1c48f28efaac475b9ba2058224e06e48  "__token__" "" "" "" "" "" "false" ""
Checking dist/numpydoc-1.8.0rc0-py3-none-any.whl: FAILED
ERROR    `long_description` has syntax errors in markup and would not be        
         rendered on PyPI.                                                      
         line 5: Warning: Cannot scale image!                                   
           Could not get size from                                              
         "https://readthedocs.org/projects/numpydoc/badge/?version=latest":     
           Requires Python Imaging Library.                                     
           Reading external files disabled.                                     
Checking dist/numpydoc-1.8.0rc0.tar.gz: FAILED
ERROR    `long_description` has syntax errors in markup and would not be        
         rendered on PyPI.                                                      
         line 5: Warning: Cannot scale image!                                   
           Could not get size from                                              
         "https://readthedocs.org/projects/numpydoc/badge/?version=latest":     
           Requires Python Imaging Library.                                     
           Reading external files disabled.   

I couldn't figure out what changed. So, for 1.8.0rc1, I just deleted the badges and readded them when I bumped the release.

@larsoner
Copy link
Collaborator

Seems like a bug with https://github.com/pypa/gh-action-pypi-publish/blob/unstable/v1/requirements/runtime.in perhaps that it should include pillow. I'll open it as a PR-as-suggestion and see what they say!

@larsoner
Copy link
Collaborator

Looks like it's really pypa/readme_renderer#304

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants