Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the sampling constructors align #73

Open
nathanielpritchard opened this issue Oct 11, 2024 · 0 comments
Open

Make the sampling constructors align #73

nathanielpritchard opened this issue Oct 11, 2024 · 0 comments
Assignees
@dmaldona @vp314
Labels
bug Something isn't working

Comments

@nathanielpritchard
Copy link
Contributor

Currently the block sampling constructors require different arguments, some key words some not, and this is confusing to the user as they are unsure what they should be inputting. This requires changes to:

  • LinSys[Col/Row]Gauss
  • LinSys[Col/Row]Replace
  • LinSys[Col/Row]Cyclic
    All the constructors should take in the key-word argument block_size and perform operations to implement the methods.
@nathanielpritchard nathanielpritchard added the bug Something isn't working label Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dmaldona dmaldona

@vp314 vp314

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dmaldona @vp314 @nathanielpritchard