Proc.Start Arguments breaking change since 0.6.x upgrade to 0.8.x

[kachalkov]

hi, we have upgraded to latest version and none of the arguments are being passed in fully due to the code which tries to split by space and add to the list.

we are using bcp process to start and pass args....

[oleg-razvaliaev]

Yes. the problem exists for arguments passed in as a single string.
Example:
something.exe "argument1 passed as parameters in quoted string" argument2 argument3
Argument2 is not passed into something.exe

[Mpdreamz]

Sorry to hear!

I tried reproducing this to no avail here: #17

Can you share how you are invoking Proc and the TFM you run under?

For netstandard2.1 we don't do any argument mutations and simply pass the arg string array to: https://learn.microsoft.com/en-us/dotnet/api/system.diagnostics.processstartinfo.argumentlist?view=net-8.0&viewFallbackFrom=netframework-4.8.1

For netstandard2.0 we don't split by spaces string[] we naively quote any item in that array that has spaces.

[kachalkov]

We tried latest release and had to rollback again as it is still broken for us :-/
Please make proc.net great again :)

[kachalkov]

Why do you need any string manipulation, that seems like not very good approach do something differently base on version?

[Mpdreamz]

I'll comment tomorrow on the why @kachalkov :)

Can you share your target framework with me?

[kachalkov]

4.8

[Mpdreamz]

Released 0.9.1 which reverses the behavior back.

The problem on Full Framework (<4.8.1) and Net Standard 2.0 is that https://learn.microsoft.com/en-us/dotnet/api/system.diagnostics.processstartinfo.argumentlist is not available.

Arguments can only be passed as a single string.

So ["hello world", "good", "day"] using a simple string join would result in 4 arguments to the process which is wrong. So the routine we had naively quoted the first argument.

I might attempt to fix this again in a later version but right now reverted it because I have limited time at the moment and wanted to unblock folks.

Let me know if 0.9.1 works again 🙏

[kachalkov]

Our devs have tried latest version and it seems has breaking changes for Start method, any chance to keep old one and mark as obsolete?

…

On Wed, 4 Dec 2024, 01:46 Martijn Laarman, ***@***.***> wrote: Released 0.9.1 which reverses the behavior back. The problem on Full Framework (<4.8.1) and Net Standard 2.0 is that https://learn.microsoft.com/en-us/dotnet/api/system.diagnostics.processstartinfo.argumentlist is not available. Arguments can only be passed as a single string. So ["hello world", "good", "day"] using a simple string join would result in 4 arguments to the process which is wrong. So the routine we had naively quoted the first argument. I might attempt to fix this again in a later version but right now reverted it because I have limited time at the moment and wanted to unblock folks. Let me know if 0.9.1 works again 🙏 — Reply to this email directly, view it on GitHub <#15 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAHJ2QYKBUI5BP26LEZVX2L2DW725AVCNFSM6AAAAABJFT5A3CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMJUG43TGNZWGQ> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[oleg-razvaliaev]

The changed version works Ok for our use. A little hiccup was to change the method parameters. Thanks!