Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display track bug #1110

Merged
merged 2 commits into from
Nov 29, 2021
Merged

Display track bug #1110

merged 2 commits into from
Nov 29, 2021

Conversation

Yahyakiani
Copy link
Contributor

Resolves issue #1095 . Now time track will show according to the renderTrack value. Wrote a test for PlayerBarContainer as well. Although it seems a couple more can be written in that case.

@nukeop
Copy link
Owner

nukeop commented Nov 29, 2021

Nice one, thanks for fixing this.

Looks like snapshots don't pass, I'll fix that manually. Next time, please remember to update snapshots by running npm test -- -u in the package that needs new snapshots (such as when the way elements are rendered changes).

@nukeop nukeop merged commit d657404 into nukeop:master Nov 29, 2021
@Yahyakiani Yahyakiani deleted the display_track_bug branch November 29, 2021 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants