Wrap all text in i18next functions #1087
Conversation
Wrapped hard-coded text
|
Thanks for your contributions. Since we use Crowdin for managing translation, you don't need to update keys in all language files only need to change in |
|
Absolutely! We’ll get to work on it.
…On Mon, Nov 8, 2021 at 12:03 AM Felix ***@***.***> wrote:
Thanks for your contributions. Since we use Crowdin for managing
translation, you don't need to update keys in all language files only need
to change in en.json. Can you use please remove those changes?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1087 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFIKCD3JPKWFLXUZKE7OY4TUK575DANCNFSM5HP275LA>
.
|
|
Great, thank you, and thanks for setting this straight. |
|
All you have to do is just revert all files in i18n that are not en.json. |
|
Got it! I deleted all added keys from all language JSON files except for
en.json. Just checking my work with my team.
…On Mon, Nov 8, 2021 at 12:22 PM nukeop ***@***.***> wrote:
All you have to do is just revert all files in i18n that are not en.json.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1087 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFIKCD4AVI4KY5BL32BY4Z3ULAWPZANCNFSM5HP275LA>
.
|
Deleted added keys from all language JSON files except en.json for nukeop#647
|
My team and I reverted all language JSON files back to what they were except for en.json. |
|
You have to update snapshot test to make the CI pass. |
|
Hi, I am one of the members who is working on this pull request. All of us are beginner coders, could you further explain what do you mean by updating the snapshot test to make the CI pass? |
|
There is a test to ensure UI render as expected, it's called snapshot testing. When there is a modify in UI the test will fail cos it compares with the previous UI. About CI, one of its jobs in nuclear is checking all tests pass in PR. In short, you need to run the test with '--updateSnapshot' key. |
|
After you run |
Every time I run 'npm test -- -u' I get the error "ERR! lerna Unknown argument: u". Do I need to install something to make this work? |
|
Try going to |
|
|
Updated the snapshot test
|
Nice work, one last thing that revert change in other language file |
|
My teammate @odiaz95012 seemed to have reverted all changes in other language files. Is there any part that we have left out? |
Did your friend push the commit, those changes still in PR. You can see in the |
Yes, I pushed the changes where I got rid off all the keys we added from all language files except en.json. |
|
I got it, there was a change on last line in other files but I think it OK to skip. |
|
The whitespace changes are fine, but it looks like snapshots do not pass, I'll check it out later today. |
|
Oh, no. Was it because of my snapshot? Please feel free to let us know whatever needed to be fixed. |
|
It's because the test setup for settings doesn't have internationalization enabled (since the strings were hardcoded up until now), I'm fixing this now. |
Codecov Report
@@ Coverage Diff @@
## master #1087 +/- ##
==========================================
- Coverage 61.39% 61.38% -0.01%
==========================================
Files 280 280
Lines 5082 5089 +7
Branches 359 361 +2
==========================================
+ Hits 3120 3124 +4
- Misses 1658 1660 +2
- Partials 304 305 +1
Continue to review full report at Codecov.
|
I was able to wrap all the hard-coded text using the i18next functions along with my teammates @odiaz95012 and @ramy-meng. We also added the keys to the different language json files so they can be translated.
Closes #647