Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return Result instead of Option in Capsule::open_reencrypted()? #20

Closed
fjarri opened this issue Nov 29, 2020 · 0 comments · Fixed by #45
Closed

Return Result instead of Option in Capsule::open_reencrypted()? #20

fjarri opened this issue Nov 29, 2020 · 0 comments · Fixed by #45
Labels
API Related to public API
Milestone
v0.2.0

Comments

@fjarri
Copy link
Contributor

fjarri commented Nov 29, 2020

Capsule::open_reencrypted() can fail in several different ways:

  • an empty cfrag list is provided
  • mismatched cfrags (different precursors)
  • mismatched capsule (internal verification fails)
  • two polynomial coefficients equal to each other (very rare, or someone tampered with the input)
  • digest of the secret value d is zero (very rare, or someone tampered with the input)

For all of this None is returned. Do we want to differentiate between these errors?
@fjarri fjarri added the API Related to public API label Nov 29, 2020
@fjarri fjarri mentioned this issue Mar 28, 2021
Merged
@fjarri fjarri added this to the v0.1.0 milestone Apr 7, 2021
@fjarri fjarri closed this as completed in #45 May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
API Related to public API
Projects
None yet
Milestone
v0.2.0
Development

Successfully merging a pull request may close this issue.

Error handling for Rust and Python fjarri/rust-umbral
1 participant
@fjarri