Interfacing with Rust, part 2 #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derekpierre
reviewed
Apr 20, 2021
umbral/signing.py
Outdated
| # Try `r` | ||
| q = (rs - ge) * inv_r | ||
| if q == public_key.point(): | ||
| return False |
There was a problem hiding this comment.
Noticed this yesterday during the walkthrough - how come this returns False?
There was a problem hiding this comment.
This function returns a recovery byte, which can only be \x00 or \x01, so I return a boolean flag instead.
fjarri
force-pushed
the
interfacing-2
branch
3 times, most recently
from
a173e62
to
48faa64
Compare
fjarri
force-pushed
the
interfacing-2
branch
3 times, most recently
from
856b508
to
40474db
Compare
fjarri
requested review from
cygnusv,
KPrasch,
tuxxy,
derekpierre,
jMyles,
vepkenez and
piotr-roslaniec
cygnusv
approved these changes
May 26, 2021
piotr-roslaniec
approved these changes
May 26, 2021
Have to regenerate the vectors because kfrag signature is now created with a different DST
…ng_pk to verifying_pk
…of KeyFrag.verify()
Have to rebuild vectors again.
fjarri
force-pushed
the
interfacing-2
branch
7 times, most recently
from
8d88535
to
d1a37c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More changes based on the needs of
nucypher. Based on top of #263Synchronized with nucypher/rust-umbral@3cba902
generate_kfrags()take it instead of the secret keysigning_pk->verifying_pk)generate_kfrags()topre.py(where the rest of high-level API resides)openssl.pyCurvePoint.from_affine()is removed