Skip to content

keep the output of linear tree-based model as probability estimates #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

will945945945
Copy link
Contributor

@will945945945 will945945945 commented Dec 9, 2024

The outputs of a tree-based model should be in the range [0, 1]^{# of label},
which is corresponding to the probability estimates.
Moreover, if we want to use sparse matrix to store the prediction values of a tree model,
the value ``-inf'' will be a trouble issue.

What does this PR do?

  1. modify the initial value of predictions from -inf to 0
  2. replace the description decision values'' to probability estimates.''

Test CLI & API (bash tests/autotest.sh)

Test APIs used by main.py.

  • Test Pass
    • (Copy and paste the last outputted line here.)
  • Not Applicable (i.e., the PR does not include API changes.)

Check API Document

If any new APIs are added, please check if the description of the APIs is added to API document.

  • API document is updated (linear, nn)
  • Not Applicable (i.e., the PR does not include API changes.)

Test quickstart & API (bash tests/docs/test_changed_document.sh)

If any APIs in quickstarts or tutorials are modified, please run this test to check if the current examples can run correctly after the modified APIs are released.

… label}, which is corresponding to the probability estimates.

Moreover, if we want to use sparse matrix to store the prediction values of a tree model, the value ``-inf'' will be a trouble issue.
@Eleven1Liu Eleven1Liu merged commit 7c7533e into ntumlgroup:master Dec 10, 2024
1 check passed
@will945945945 will945945945 deleted the output_prob_in_tree branch December 12, 2024 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants