Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Require aiohttp v3.9.0+ #789

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

matthewfeickert
Copy link
Contributor

What does this PR do?

* Provide a lower bound of v3.9.0 for aiohttp.
@matthewfeickert matthewfeickert mentioned this pull request Apr 2, 2024
Copy link

codecov bot commented Apr 3, 2024

Codecov Report

Merging #789 (be2cf75) into main (cb2eb37) will decrease coverage by 0.26%.
Report is 7 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #789      +/-   ##
==========================================
- Coverage   91.54%   91.29%   -0.26%     
==========================================
  Files          17       17              
  Lines        1621     1631      +10     
==========================================
+ Hits         1484     1489       +5     
- Misses        137      142       +5     

@matthewfeickert
Copy link
Contributor Author

For whatever reason Codedcov is failing coverage, while it is passing on main, but that is safe to ignore as this is a 1-line diff.

@MSeal MSeal enabled auto-merge (squash) April 3, 2024 12:57
@MSeal MSeal disabled auto-merge April 3, 2024 12:57
@MSeal MSeal merged commit cb9fd06 into nteract:main Apr 3, 2024
12 of 13 checks passed
@matthewfeickert matthewfeickert deleted the build/give-lower-bound branch April 3, 2024 22:04
@matthewfeickert
Copy link
Contributor Author

Thanks for the fast review and merge, @MSeal!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants