Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-commit fixes #763

Merged
merged 3 commits into from
Dec 18, 2023
Merged

Pre-commit fixes #763

merged 3 commits into from
Dec 18, 2023

Conversation

akx
Copy link
Member

@akx akx commented Dec 18, 2023

What does this PR do?

This PR cleans up the pre-commit configuration slightly:

  • Python 3.8 is no longer required to run the tools
  • yesqa isn't necessary, since it's depending on flake8 (the use of which was dropped in switch flake8 -> ruff #752)
  • Ruff has rules for Pyupgrade, so it isn't necessary as a separate hook either

Some of the f-string changes the pyupgrade commit does are also done in #762, so these will conflict slightly.

I didn't enable ruff-format, since the current quote style in this repository is mixed, and that's not (yet: astral-sh/ruff#9185) supported by Ruff's formatter.

Copy link

codecov bot commented Dec 18, 2023

Codecov Report

Merging #763 (a401b15) into main (2bbb650) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #763   +/-   ##
=======================================
  Coverage   91.49%   91.49%           
=======================================
  Files          17       17           
  Lines        1622     1622           
=======================================
  Hits         1484     1484           
  Misses        138      138           

@MSeal MSeal merged commit 6864fdc into nteract:main Dec 18, 2023
13 checks passed
@MSeal
Copy link
Member

MSeal commented Dec 18, 2023

Thanks for the cleanup!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants