Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create cell form templates notes #12

Merged
merged 1 commit into from
Feb 7, 2019
Merged

create cell form templates notes #12

merged 1 commit into from
Feb 7, 2019

Conversation

rgbkrk
Copy link
Member

@rgbkrk rgbkrk commented Feb 6, 2019

Initial notes for cell forms / cell form templates.

I took some liberties in terms of swapping templates for cell-forms in some areas. If it seems wrong, feel free to follow it up with a new PR!

cc @mpacer @willingc @mckev-amazon

Initial notes for cell forms / cell form templates
@rgbkrk rgbkrk changed the title create cell form templates create cell form templates notes Feb 7, 2019
@rgbkrk rgbkrk merged commit f7017e8 into master Feb 7, 2019
@rgbkrk rgbkrk deleted the cell-forms branch February 7, 2019 00:25
@willingc
Copy link
Member

willingc commented Feb 7, 2019

Thanks @rgbkrk. Tossing in my two cents - I wonder if jupyter template would be better than pip install since we can add more logic to introspect the python environment than with pip. Just a thought...

@rgbkrk
Copy link
Member Author

rgbkrk commented Feb 8, 2019

Yeah I like jupyter template better too. I included both since I was just copying what was on the whiteboard. We can delete the pip version here.

@rgbkrk rgbkrk mentioned this pull request Feb 8, 2019
@mckev-amazon
Copy link

Just a quick update on this just to make sure you knew I haven't forgotten about this. :-)

I think this would be a great candidate for running through the JEP process proposed here. I can find an owner here to get the ball rolling. @rgbkrk WDYT?

@rgbkrk
Copy link
Member Author

rgbkrk commented Feb 25, 2019

Sounds great to me! I'm going to be less responsive for a few months with a baby about to be due, but I'm supportive of the cell forms moving forward. 😄

@mckev-amazon
Copy link

Just a heads up on this, my hands are a little full with the new JEP Process, and Dependency Management JEPs (still work in progress), so @pierrebrunelle (from Eider) is going to put together the JEP for the cell forms/templates feature, so we should expect a JEP pre-proposal for this feature relatively soon (this week or next).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants