Skip to content

Remove skip-duplicate option from NuGet push command - #988

Merged
dtchepak merged 1 commit into
mainfrom
remove-skip-duplicate
Aug 9, 2026
Merged

Remove skip-duplicate option from NuGet push command#988
dtchepak merged 1 commit into
mainfrom
remove-skip-duplicate

Conversation

@zvirja

@zvirja zvirja commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

Follow up on #987. Remove skip-duplicate options, as I realized it would be nicer to fail and make it explicit. A new thought next morning :)

@zvirja
zvirja requested a review from dtchepak August 9, 2026 07:10

@dtchepak dtchepak left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @zvirja . 🫶

Happy to go with trigger-on-tag, although would like to have a guard rail that prevents that if CHANGELOG isn't updated (e.g. still has unreleased heading, or latest version doesn't match tag), but can look at that in a separate commit (or just drop changelog in favour of github releases changelogs?)

@dtchepak
dtchepak merged commit ef6ddd5 into main Aug 9, 2026
4 checks passed
@zvirja

zvirja commented Aug 9, 2026

Copy link
Copy Markdown
Contributor Author

@dtchepak Shall we proceed with GitHub change log and drop our own one? I feel that:

  • Simpler and we will have less burden maintaining it
  • GitHub generates it pretty good
  • Higher changes of being consistent as we could easily overlook updating change log (I do that all the time)
  • I don't think a lot of people are reading it. Rather they just use new lib and throw bugs
  • In days of AI it will most likely be read by AI anyway. And it can read GitHub one.

This way we'll be also more aligned with other repos, as most of them use GH these days. And less hassle for us 😊

@dtchepak

dtchepak commented Aug 9, 2026

Copy link
Copy Markdown
Member

@zvirja yeah happy to drop changelog in that case. I can manually edit release notes to include thanks for people that have helped out (often that doesn't come across from just the commits).

I was about to prep 6.2 release with the generic matches fix but maybe we can do this via the new process instead (very excited! 😂 ).

I've updated the release procedure but please fix up any details I've stuffed up if you get a chance 🙏

@zvirja
zvirja deleted the remove-skip-duplicate branch August 9, 2026 19:35
This was referenced Aug 11, 2026
This was referenced Aug 24, 2026
renebentes pushed a commit to renebentes/3054 that referenced this pull request Aug 24, 2026
Updated [NSubstitute](https://github.com/nsubstitute/NSubstitute) from
6.1.0 to 6.2.0.

<details>
<summary>Release notes</summary>

_Sourced from [NSubstitute's
releases](https://github.com/nsubstitute/NSubstitute/releases)._

## 6.2.0

# NSubstitute v6.2.0

This release improves generic call matching (#​989, #​974, #​990).
Thanks to @​zvirja and @​JMolenkamp for fixes this.
We've also switched to using trusted nuget publishing linked to GitHub
Releases. (#​987, @​zvirja)

## What's Changed

* Add trusted nuget publish by @​zvirja in
nsubstitute/NSubstitute#987
* fix: Stop using return-type assignability for generic call matching by
@​zvirja in nsubstitute/NSubstitute#989
* Remove skip-duplicate option from NuGet push command by @​zvirja in
nsubstitute/NSubstitute#988
* Add tag trigger for release pipeline by @​zvirja in
nsubstitute/NSubstitute#991
* Fix broken comparison of the generic methods by @​zvirja in
nsubstitute/NSubstitute#990
* Support C# 13 params collections in argument matching by @​zvirja in
nsubstitute/NSubstitute#993
* Add tests for nullable Task by @​zvirja in
nsubstitute/NSubstitute#994

**Full Changelog**:
nsubstitute/NSubstitute@v6.1.0...v6.2.0

Commits viewable in [compare
view](nsubstitute/NSubstitute@v6.1.0...v6.2.0).
</details>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants