Remove skip-duplicate option from NuGet push command - #988
Conversation
dtchepak
left a comment
There was a problem hiding this comment.
Thanks a lot @zvirja . 🫶
Happy to go with trigger-on-tag, although would like to have a guard rail that prevents that if CHANGELOG isn't updated (e.g. still has unreleased heading, or latest version doesn't match tag), but can look at that in a separate commit (or just drop changelog in favour of github releases changelogs?)
|
@dtchepak Shall we proceed with GitHub change log and drop our own one? I feel that:
This way we'll be also more aligned with other repos, as most of them use GH these days. And less hassle for us 😊 |
|
@zvirja yeah happy to drop changelog in that case. I can manually edit release notes to include thanks for people that have helped out (often that doesn't come across from just the commits). I was about to prep 6.2 release with the generic matches fix but maybe we can do this via the new process instead (very excited! 😂 ). I've updated the release procedure but please fix up any details I've stuffed up if you get a chance 🙏 |
Updated [NSubstitute](https://github.com/nsubstitute/NSubstitute) from 6.1.0 to 6.2.0. <details> <summary>Release notes</summary> _Sourced from [NSubstitute's releases](https://github.com/nsubstitute/NSubstitute/releases)._ ## 6.2.0 # NSubstitute v6.2.0 This release improves generic call matching (#989, #974, #990). Thanks to @zvirja and @JMolenkamp for fixes this. We've also switched to using trusted nuget publishing linked to GitHub Releases. (#987, @zvirja) ## What's Changed * Add trusted nuget publish by @zvirja in nsubstitute/NSubstitute#987 * fix: Stop using return-type assignability for generic call matching by @zvirja in nsubstitute/NSubstitute#989 * Remove skip-duplicate option from NuGet push command by @zvirja in nsubstitute/NSubstitute#988 * Add tag trigger for release pipeline by @zvirja in nsubstitute/NSubstitute#991 * Fix broken comparison of the generic methods by @zvirja in nsubstitute/NSubstitute#990 * Support C# 13 params collections in argument matching by @zvirja in nsubstitute/NSubstitute#993 * Add tests for nullable Task by @zvirja in nsubstitute/NSubstitute#994 **Full Changelog**: nsubstitute/NSubstitute@v6.1.0...v6.2.0 Commits viewable in [compare view](nsubstitute/NSubstitute@v6.1.0...v6.2.0). </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Follow up on #987. Remove
skip-duplicateoptions, as I realized it would be nicer to fail and make it explicit. A new thought next morning :)