Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not ignore errors ever #2800

Open
carpawell opened this issue Apr 2, 2024 · 2 comments
Open

Do not ignore errors ever #2800

carpawell opened this issue Apr 2, 2024 · 2 comments
Labels
enhancement Improving existing functionality I4 No visible changes neofs-adm NeoFS Adm application issues neofs-cli NeoFS CLI application issues neofs-lens NeoFS Lens app issues S4 Routine U4 Nothing urgent

Comments

@carpawell
Copy link
Member

Expected Behavior

Never ignore errors in gonang.

Current Behavior

Code may ignore some errors (even if they are not expected at all, that is not good).

Possible Solution

Panic if an error is not expected at all.

Context

At least CLIs are affected: binding flags, getting flags, marking flags.
Some other places may be affected too.

@carpawell carpawell added enhancement Improving existing functionality neofs-cli NeoFS CLI application issues neofs-adm NeoFS Adm application issues U4 Nothing urgent neofs-lens NeoFS Lens app issues S4 Routine I4 No visible changes labels Apr 2, 2024
@roman-khimov
Copy link
Member

Narrow down the scope, please. This is too broad.

@carpawell
Copy link
Member Author

Narrow down the scope, please.

Finding all the places == 90% of solving the issue. We do ignore errors sometimes (Context has 3 examples with cobra lib errs ignorance). What exact do you mean?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improving existing functionality I4 No visible changes neofs-adm NeoFS Adm application issues neofs-cli NeoFS CLI application issues neofs-lens NeoFS Lens app issues S4 Routine U4 Nothing urgent
Projects
None yet
Development

No branches or pull requests

2 participants