Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Objects forwarding does not track success progress #2047

Closed
carpawell opened this issue Nov 11, 2022 · 0 comments · Fixed by #2122
Closed

Objects forwarding does not track success progress #2047

carpawell opened this issue Nov 11, 2022 · 0 comments · Fixed by #2122
Assignees
Labels
bug Something isn't working discussion Open discussion of some problem neofs-storage Storage node application issues U2 Seriously planned

Comments

@carpawell
Copy link
Member

carpawell commented Nov 11, 2022

Context

If a node is forwarding a request to another node, it does not track the success of the operation. It leads to a data duplication from the original caller's point of view, e.g. double header sendings:

▶ neofs-cli -r s02.neofs.devenv:8080 --bearer tmp/b.signed.json -w ./services/s3_gate/wallet.json object get --cid Gq4Zcj5tsLRhwi9RFLYu5F8W4KRzgsS6Y3mEHukk3Ecv --oid Habd23jp299wWWC5o1LF5S485cUUQfazgqsF5MMRDvTx --file trash.file
Enter password > 
 2000000 / 12000000 [====================================>------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------]  16.67% 0s
rpc error: copy payload: unexpected message instead of chunk part: *object.GetObjectPartInit

First time was found in #2045.

Reproducing:

  1. Make a big object (huge enough to have num of children >> num of nodes to make the bug more reproducible) to be placed on more than 1 node;
  2. Send a request to a node that does not have a splitID of the object (e.g. non-container node) to force it to forward the request;
  3. Make any other node that contains the part of the object not finish their response (acl problem, remove the obj physically, mb just stop it);
  4. See how the assembling is starting from scratch and the requested node is answering with the data you already received.
@carpawell carpawell added bug Something isn't working discussion Open discussion of some problem triage neofs-storage Storage node application issues U2 Seriously planned labels Nov 11, 2022
@carpawell carpawell self-assigned this Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working discussion Open discussion of some problem neofs-storage Storage node application issues U2 Seriously planned
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants