Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

neofs-adm waits for potentially useless transactions #1788

Open
carpawell opened this issue Sep 15, 2022 · 0 comments
Open

neofs-adm waits for potentially useless transactions #1788

carpawell opened this issue Sep 15, 2022 · 0 comments
Labels
discussion Open discussion of some problem good first issue Good for newcomers I4 No visible changes neofs-adm NeoFS Adm application issues S3 Minimally significant U4 Nothing urgent

Comments

@carpawell
Copy link
Member

It is common practice to send some TXs, cache their hashes, and wait for their chain inclusion.

Adm CLI stops if one of the TX has not been persisted but does not stop if one of the TX was failed. Moreover, we return only the first not-HALT-err and drop other errors.

I suggest just stopping iterating on any non-HALT TX. It also would simplify the code.
@carpawell carpawell added good first issue Good for newcomers discussion Open discussion of some problem triage neofs-adm NeoFS Adm application issues U4 Nothing urgent labels Sep 15, 2022
@carpawell carpawell mentioned this issue Sep 15, 2022
Merged
@carpawell carpawell changed the title DoD for steps in neofs-adm neofs-adm waits for potentially useless transactions Sep 15, 2022
@carpawell carpawell added 2022Q4 and removed 2022Q3 labels Oct 10, 2022
@roman-khimov roman-khimov added S3 Minimally significant I4 No visible changes and removed triage labels Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
discussion Open discussion of some problem good first issue Good for newcomers I4 No visible changes neofs-adm NeoFS Adm application issues S3 Minimally significant U4 Nothing urgent
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@roman-khimov @carpawell