Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Endless notary deposits #1486

Closed
carpawell opened this issue Jun 7, 2022 · 0 comments · Fixed by #2121
Closed

Endless notary deposits #1486

carpawell opened this issue Jun 7, 2022 · 0 comments · Fixed by #2121
Assignees
Labels
bug Something isn't working discussion Open discussion of some problem help wanted Extra attention is needed neofs-ir Inner Ring node application issues neofs-storage Storage node application issues question Further information is requested U3 Regular

Comments

@carpawell
Copy link
Member

carpawell commented Jun 7, 2022

Context

We experience fallback transaction is valid after the deposit is unlocked: ValidUntilBlock is 8900, deposit lock expires at 8058 errors sometimes. Their nature is not fully understood but the fact is that we lost some deposits.

Suggestion

Try to use the biggest till always (e.g. max int64).

Pitfalls of this question:

  1. I do not remember if it is allowed to make the same notary deposits (the same till, the same amount).
  2. Doing a deposit with max int64 forces us to use the same till in all the further deposits (it is impossible to make deposits with newTill < currentTill).
  3. We have the same deposit logic in the side and main chains. While it is kinda ok to block some GAS forever in the sidechain, doing that in the main chain may have some misunderstanding (if we ever have notary turned on in the main chain).

Also

  1. New logs on notary deposits (with the amount, till, and epoch) could be useful for debugging.
@carpawell carpawell added help wanted Extra attention is needed question Further information is requested discussion Open discussion of some problem triage neofs-ir Inner Ring node application issues neofs-storage Storage node application issues bug Something isn't working labels Jun 7, 2022
@alexchetaev alexchetaev added U2 Seriously planned 2022Q4 labels Aug 23, 2022
@alexchetaev alexchetaev added U3 Regular and removed U2 Seriously planned 2022Q4 labels Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working discussion Open discussion of some problem help wanted Extra attention is needed neofs-ir Inner Ring node application issues neofs-storage Storage node application issues question Further information is requested U3 Regular
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants