From 466b9b4273203a293b00620b8475c24e9daf7abe Mon Sep 17 00:00:00 2001 From: Pavel Karpy Date: Wed, 11 May 2022 21:35:49 +0300 Subject: [PATCH] [#1593] adm: Support changing network config Signed-off-by: Pavel Karpy --- cmd/neofs-adm/README.md | 2 + .../modules/morph/{dump.go => config.go} | 91 +++++++++++++++++++ cmd/neofs-adm/internal/modules/morph/root.go | 17 ++++ 3 files changed, 110 insertions(+) rename cmd/neofs-adm/internal/modules/morph/{dump.go => config.go} (68%) diff --git a/cmd/neofs-adm/README.md b/cmd/neofs-adm/README.md index 735272e889..6d28fe19fd 100644 --- a/cmd/neofs-adm/README.md +++ b/cmd/neofs-adm/README.md @@ -70,6 +70,8 @@ credentials: # passwords for consensus node / alphabet wallets #### Network maintenance +- `set-config` add/update configuration values in the Netmap contract. + - `force-new-epoch` increments NeoFS epoch number and executes new epoch handlers in NeoFS nodes. diff --git a/cmd/neofs-adm/internal/modules/morph/dump.go b/cmd/neofs-adm/internal/modules/morph/config.go similarity index 68% rename from cmd/neofs-adm/internal/modules/morph/dump.go rename to cmd/neofs-adm/internal/modules/morph/config.go index 2f8a44037d..13575f1f90 100644 --- a/cmd/neofs-adm/internal/modules/morph/dump.go +++ b/cmd/neofs-adm/internal/modules/morph/config.go @@ -6,6 +6,8 @@ import ( "encoding/hex" "errors" "fmt" + "strconv" + "strings" "text/tabwriter" "github.com/nspcc-dev/neo-go/pkg/io" @@ -21,6 +23,8 @@ import ( const lastGlagoliticLetter = 41 +const forceConfigSet = "force" + type contractDumpInfo struct { hash util.Uint160 name string @@ -209,3 +213,90 @@ func dumpNetworkConfig(cmd *cobra.Command, _ []string) error { return nil } + +func setConfigCmd(cmd *cobra.Command, args []string) error { + if len(args) == 0 { + return errors.New("empty config pairs") + } + + wCtx, err := newInitializeContext(cmd, viper.GetViper()) + if err != nil { + return fmt.Errorf("can't initialize context: %w", err) + } + + cs, err := wCtx.Client.GetContractStateByID(1) + if err != nil { + return fmt.Errorf("can't get NNS contract info: %w", err) + } + + nmHash, err := nnsResolveHash(wCtx.Client, cs.Hash, netmapContract+".neofs") + if err != nil { + return fmt.Errorf("can't get netmap contract hash: %w", err) + } + + forceFlag, _ := cmd.Flags().GetBool(forceConfigSet) + + bw := io.NewBufBinWriter() + for _, arg := range args { + k, v, err := parseConfigPair(arg, forceFlag) + if err != nil { + return err + } + + // In NeoFS this is done via Notary contract. Here, however, we can form the + // transaction locally. The first `nil` argument is required only for notary + // disabled environment which is not supported by that command. + emit.AppCall(bw.BinWriter, nmHash, "setConfig", callflag.All, nil, k, v) + if bw.Err != nil { + return fmt.Errorf("can't form raw transaction: %w", bw.Err) + } + } + + err = wCtx.sendCommitteeTx(bw.Bytes(), -1, true) + if err != nil { + return err + } + + return wCtx.awaitTx() +} + +func parseConfigPair(kvStr string, force bool) (key string, val interface{}, err error) { + kv := strings.SplitN(kvStr, "=", 2) + if len(kv) != 2 { + return "", nil, fmt.Errorf("invalid parameter format: must be 'key=val', got: %s", kvStr) + } + + key = kv[0] + valRaw := kv[1] + + switch key { + case netmapAuditFeeKey, netmapBasicIncomeRateKey, + netmapContainerFeeKey, netmapContainerAliasFeeKey, + netmapEigenTrustIterationsKey, + netmapEpochKey, netmapInnerRingCandidateFeeKey, + netmapMaxObjectSizeKey, netmapWithdrawFeeKey: + val, err = strconv.ParseInt(valRaw, 10, 64) + if err != nil { + err = fmt.Errorf("could not parse %s's value '%s' as int: %w", key, valRaw, err) + } + case netmapEigenTrustAlphaKey: + // just check that it could + // be parsed correctly + _, err = strconv.ParseFloat(kv[1], 64) + if err != nil { + err = fmt.Errorf("could not parse %s's value '%s' as float: %w", key, valRaw, err) + } + + val = valRaw + default: + if !force { + return "", nil, fmt.Errorf( + "'%s' key is not well-known, use '--%s' flag if want to set it anyway", + key, forceConfigSet) + } + + val = valRaw + } + + return +} diff --git a/cmd/neofs-adm/internal/modules/morph/root.go b/cmd/neofs-adm/internal/modules/morph/root.go index 66527a3b91..f9b0126824 100644 --- a/cmd/neofs-adm/internal/modules/morph/root.go +++ b/cmd/neofs-adm/internal/modules/morph/root.go @@ -122,6 +122,18 @@ var ( RunE: removeNodesCmd, } + setConfig = &cobra.Command{ + Use: "set-config key1=val1 [key2=val2 ...]", + DisableFlagsInUseLine: true, + Short: "Add/update global config value in the NeoFS network", + PreRun: func(cmd *cobra.Command, _ []string) { + _ = viper.BindPFlag(alphabetWalletsFlag, cmd.Flags().Lookup(alphabetWalletsFlag)) + _ = viper.BindPFlag(endpointFlag, cmd.Flags().Lookup(endpointFlag)) + }, + Args: cobra.MinimumNArgs(1), + RunE: setConfigCmd, + } + setPolicy = &cobra.Command{ Use: "set-policy [ExecFeeFactor=] [StoragePrice=] [FeePerByte=]", DisableFlagsInUseLine: true, @@ -241,6 +253,11 @@ func init() { RootCmd.AddCommand(dumpNetworkConfigCmd) dumpNetworkConfigCmd.Flags().StringP(endpointFlag, "r", "", "N3 RPC node endpoint") + RootCmd.AddCommand(setConfig) + setConfig.Flags().String(alphabetWalletsFlag, "", "path to alphabet wallets dir") + setConfig.Flags().StringP(endpointFlag, "r", "", "N3 RPC node endpoint") + setConfig.Flags().Bool(forceConfigSet, false, "Force setting not well-known configuration key") + RootCmd.AddCommand(dumpBalancesCmd) dumpBalancesCmd.Flags().StringP(endpointFlag, "r", "", "N3 RPC node endpoint") dumpBalancesCmd.Flags().BoolP(dumpBalancesStorageFlag, "s", false, "dump balances of storage nodes from the current netmap")