This repository has been archived by the owner on Aug 20, 2024. It is now read-only.
Add connectTimeout option #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgodson
commented
Oct 15, 2020
| } | ||
| }); | ||
|
|
||
| // TODO: do reject here and handle this later on | ||
| proxyReq.on('error', function(err) { | ||
| // reject(error); | ||
| if (err.code === 'ECONNRESET') { | ||
| ctx.set('X-Timout-Reason', 'koa-better-http-proxy timed out your request after ' + options.timeout + 'ms.'); | ||
| ctx.set('X-Timout-Reason', 'koa-better-http-proxy timed out your request after ' + timeoutDuration + 'ms.'); |
There was a problem hiding this comment.
There's a typo in this header, but that could be a breaking change technically so I left it alone
jgodson
commented
Oct 15, 2020
|
|
||
| describe('when connectTimeout option is set lower than server connect time', function() { | ||
| it('should fail with CONNECTION TIMEOUT', function(done) { | ||
| http.use(proxy('http://127.0.0.0', { |
There was a problem hiding this comment.
I wanted to find a seemingly more "legit" way to make this happen, but I couldn't and this seems to work 🤷♂️
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new option to supply a separate timeout for a connection to be made. This allows you to fail fast if there are dns or network issues if you need a longer timeout in general (or don't want to set a timeout at all)