error: finish changes to several C modules to use box.error

We already do some steps to use box.error in these C modules. Let's
finish it to make a clear distinction between C modules that are
switched to box.error and that are not.

Follow-up tarantool#9996

NO_CHANGELOG=internal
NO_DOC=internal

Author: nshy

src/box/lua/call.c

@@ -1089,8 +1089,10 @@ lbox_func_call(struct lua_State *L)
 {
 	if (box_check_configured() != 0)
 		return luaT_error(L);
-	if (lua_gettop(L) < 1 || !lua_isstring(L, 1))
-		return luaL_error(L, "Use func:call(...)");
+	if (lua_gettop(L) < 1 || !lua_isstring(L, 1)) {
+		diag_set(IllegalParams, "Use func:call(...)");
+		return luaT_error(L);
+	}
 
 	size_t name_len;
 	const char *name = lua_tolstring(L, 1, &name_len);

src/box/lua/index.c

@@ -372,7 +372,7 @@ lbox_iterator_next(lua_State *L)
 static int
 lbox_truncate(struct lua_State *L)
 {
-	uint32_t space_id = luaL_checkinteger(L, 1);
+	uint32_t space_id = luaT_checkint(L, 1);
 	if (box_truncate(space_id) != 0)
 		return luaT_error(L);
 	return 0;

src/box/lua/init.c

@@ -581,9 +581,11 @@ lbox_rollback_to_savepoint(struct lua_State *L)
 	struct txn_savepoint *svp;
 
 	if (lua_gettop(L) != 1 ||
-	    (svp = luaT_check_txn_savepoint(L, 1, &svp_txn_id)) == NULL)
-		return luaL_error(L,
-			"Usage: box.rollback_to_savepoint(savepoint)");
+	    (svp = luaT_check_txn_savepoint(L, 1, &svp_txn_id)) == NULL) {
+		diag_set(IllegalParams,
+			 "Usage: box.rollback_to_savepoint(savepoint)");
+		return luaT_error(L);
+	}
 
 	/*
 	 * Verify that we're in a transaction and that it is the
@@ -710,9 +712,10 @@ lbox_on_##name(struct lua_State *L) {                                          \
 	struct txn *txn = in_txn();                                            \
 	int top = lua_gettop(L);                                               \
 	if (top > 3 || txn == NULL) {                                          \
-		return luaL_error(L, "Usage inside a transaction: "            \
-				  "box.on_" #name "([new_function | nil, "     \
-				  "[old_function | nil], [name | nil]])");     \
+		diag_set(IllegalParams, "Usage inside a transaction: "         \
+			 "box.on_" #name "([new_function | nil, "              \
+			 "[old_function | nil], [name | nil]])");              \
+		return luaT_error(L);                                          \
 	}                                                                      \
 	txn_init_triggers(txn);                                                \
 	return lbox_trigger_reset(L, 1, &txn->on_##name, lbox_push_txn, NULL); \
@@ -839,8 +842,11 @@ luamp_decode_extension_box(struct lua_State *L, const char **data,
 	switch (ext_type) {
 	case MP_ERROR: {
 		struct error *err = error_unpack(data, len);
-		if (err == NULL)
-			luaL_error(L, "Can not parse an error from MsgPack");
+		if (err == NULL) {
+			diag_set(IllegalParams,
+				 "Can not parse an error from MsgPack");
+			luaT_error(L);
+		}
 		luaT_pusherror(L, err);
 		break;
 	}
@@ -858,12 +864,14 @@ luamp_decode_extension_box(struct lua_State *L, const char **data,
 		luaT_pushtuple(L, tuple);
 		break;
 tuple_err:
-		luaL_error(L, "Can not parse a tuple from MsgPack");
+		diag_set(IllegalParams, "Can not parse a tuple from MsgPack");
+		luaT_error(L);
 		break;
 	}
 	default:
-		luaL_error(L, "Unsupported MsgPack extension type: %d",
-			   ext_type);
+		diag_set(IllegalParams,
+			 "Unsupported MsgPack extension type: %d", ext_type);
+		luaT_error(L);
 	}
 }
 

test/app-tap/msgpack.test.lua

@@ -48,12 +48,12 @@ local function test_misc(test, s)
     test:is_deeply(result, {1}, "ibuf_decode result")
     test:ok(not st and e:match("null"), "null ibuf")
     st, e = pcall(s.decode, "\xd4\x0f\x00")
-    test:is(e, "Unsupported MsgPack extension type: 15",
-               "decode result for \\xd4\\x0f\\x00: " .. e)
+    test:is(tostring(e), "Unsupported MsgPack extension type: 15",
+            "decode result for \\xd4\\x0f\\x00: " .. e)
     test:ok(not st, "unsupported extension decode")
     st, e = pcall(s.decode, "\xd4\xfe\x00")
-    test:is(e, "Unsupported MsgPack extension type: -2",
-               "decode result for \\xd4\\xfe\\x00: " .. e)
+    test:is(tostring(e), "Unsupported MsgPack extension type: -2",
+            "decode result for \\xd4\\xfe\\x00: " .. e)
     test:ok(not st, "unsupported extension decode")
 end