Make Deprovisioning Status Instant (#191)

We only update resource provisioning status after a reconcile, and that
can lead to delays in showing deprovisioning status, or not showing it
at all for one shot delete.  This is particularly jarring for long
running one shot deprovisioners at the UX level.  This sets the status
to deprovisioning as soon as the deletion timestamp is set.

Author: spjmurray

pkg/server/conversion/conversion.go

@@ -41,7 +41,13 @@ var (
 )
 
 // convertStatusCondition translates from Kubernetes status conditions to API ones.
-func convertStatusCondition(in any) openapi.ResourceProvisioningStatus {
+func convertStatusCondition(in metav1.Object) openapi.ResourceProvisioningStatus {
+	// We set the status after a reconcile, so this allows us to
+	// reflect the correct state to the user immediately.
+	if in.GetDeletionTimestamp() != nil {
+		return openapi.ResourceProvisioningStatusDeprovisioning
+	}
+
 	// Not a resource with status conditions, consider it provisioned.
 	reader, ok := in.(unikornv1.StatusConditionReader)
 	if !ok {

pkg/server/conversion/conversion_test.go

@@ -144,7 +144,7 @@ func TestResourceReadMetadataAdvanced(t *testing.T) {
 	require.Equal(t, id, out.Id)
 	require.Equal(t, name, out.Name)
 	require.Equal(t, creationTime, out.CreationTime)
-	require.Equal(t, openapi.ResourceProvisioningStatusUnknown, out.ProvisioningStatus)
+	require.Equal(t, openapi.ResourceProvisioningStatusDeprovisioning, out.ProvisioningStatus)
 	require.Equal(t, openapi.ResourceHealthStatusUnknown, out.HealthStatus)
 
 	require.Equal(t, ptr.To(description), out.Description)
@@ -170,7 +170,7 @@ func TestOrganizationScopedResourceReadMetadataAdvanced(t *testing.T) {
 	require.Equal(t, id, out.Id)
 	require.Equal(t, name, out.Name)
 	require.Equal(t, creationTime, out.CreationTime)
-	require.Equal(t, openapi.ResourceProvisioningStatusUnknown, out.ProvisioningStatus)
+	require.Equal(t, openapi.ResourceProvisioningStatusDeprovisioning, out.ProvisioningStatus)
 	require.Equal(t, openapi.ResourceHealthStatusUnknown, out.HealthStatus)
 
 	require.Equal(t, ptr.To(description), out.Description)
@@ -198,7 +198,7 @@ func TestProjectScopedResourceReadMetadata(t *testing.T) {
 	require.Equal(t, id, out.Id)
 	require.Equal(t, name, out.Name)
 	require.Equal(t, creationTime, out.CreationTime)
-	require.Equal(t, openapi.ResourceProvisioningStatusUnknown, out.ProvisioningStatus)
+	require.Equal(t, openapi.ResourceProvisioningStatusDeprovisioning, out.ProvisioningStatus)
 	require.Equal(t, openapi.ResourceHealthStatusUnknown, out.HealthStatus)
 
 	require.Equal(t, ptr.To(description), out.Description)