refactor: apply general code cleanups and consistency improvements

Perform general refactoring to improve consistency, readability, and
maintainability across the codebase.

Author: alansy-nscale

pkg/manager/reference.go

@@ -55,7 +55,7 @@ func GenerateResourceReference(client client.Client, resource client.Object) (st
 
 	gvr := mapping.Resource
 
-	// TODO: This is a legacy thing where the OG Kubernetes service is not corrcetly
+	// TODO: This is a legacy thing where the OG Kubernetes service is not correctly
 	// namespaced, much like Amazon regions :D  We really need to work out a migration
 	// strategy.
 	if gvr.Group == "unikorn-cloud.org" {
@@ -68,7 +68,7 @@ func GenerateResourceReference(client client.Client, resource client.Object) (st
 // GetResourceReferences returns all resource references attached to a resource.
 // This is used primarily to poll a resource to see if it's in use, and thus its
 // deletion will have consequences.  It may also be used to inhibit deletion in
-// certain cercumstances.
+// certain circumstances.
 func GetResourceReferences(object client.Object) []string {
 	ignored := []string{
 		// Our finalizer to inhibit deletion until we are finished.

pkg/messaging/consumer/cascadingdelete.go

@@ -98,7 +98,7 @@ func (c *CascadingDelete) Consume(ctx context.Context, envelope *messaging.Envel
 	}
 
 	if c.resourceLabel != "" {
-		opts.LabelSelector = labels.SelectorFromSet(map[string]string{
+		opts.LabelSelector = labels.SelectorFromSet(labels.Set{
 			c.resourceLabel: envelope.ResourceID,
 		})
 	}

pkg/server/conversion/conversion.go

@@ -166,7 +166,7 @@ func OrganizationScopedResourceReadMetadata(in metav1.Object, tags unikornv1.Tag
 	return out
 }
 
-// ProjectScopedResourceReadMetadata extracts project scoped metdata from a resource for
+// ProjectScopedResourceReadMetadata extracts project scoped metadata from a resource for
 // GET APIs.
 //
 //nolint:errchkjson
@@ -304,12 +304,10 @@ func LogUpdate(ctx context.Context, current, required metav1.Object) error {
 }
 
 func ConvertTag(in unikornv1.Tag) openapi.Tag {
-	out := openapi.Tag{
+	return openapi.Tag{
 		Name:  in.Name,
 		Value: in.Value,
 	}
-
-	return out
 }
 
 func ConvertTags(in unikornv1.TagList) openapi.TagList {
@@ -327,12 +325,10 @@ func ConvertTags(in unikornv1.TagList) openapi.TagList {
 }
 
 func GenerateTag(in openapi.Tag) unikornv1.Tag {
-	out := unikornv1.Tag{
+	return unikornv1.Tag{
 		Name:  in.Name,
 		Value: in.Value,
 	}
-
-	return out
 }
 
 func GenerateTagList(in *openapi.TagList) unikornv1.TagList {