fix(core): skip vt100 parsing if tui disabled #31010
Merged
+40
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
View your CI Pipeline Execution ↗ for commit 0dc5585.
☁️ Nx Cloud last updated this comment at |
AgentEnder
force-pushed
the
fix/no-vt100-on-ci
branch
from
c107097 to
8807309
Compare
JamesHenry
approved these changes
May 2, 2025
🐳 We have a release for that!This PR has a release associated with it. You can try it out using this command: npx create-nx-workspace@0.0.0-pr-31010-8807309 my-workspaceOr just copy this version and use it in your own command: 0.0.0-pr-31010-8807309
To request a new release for this pull request, mention someone from the Nx team or the |
🐳 We have a release for that!This PR has a release associated with it. You can try it out using this command: npx create-nx-workspace@0.0.0-pr-31010-0dc5585 my-workspaceOr just copy this version and use it in your own command: 0.0.0-pr-31010-0dc5585
To request a new release for this pull request, mention someone from the Nx team or the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
nx@21.0.0-rc.2 is failing on circle ci because it registers as a tty
Expected Behavior
We don't deal with vt100 unless in the tui, which doesn't happen on ci
Related Issue(s)
Fixes #