feat(expo): support cjs and mjs #21408
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 9336b50. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
yzhe554
force-pushed
the
feature/support-cjs-and-mjs
branch
from
12900c2 to
19140fc
Compare
Contributor
|
@yzhe554 besides the migration script, could you update the metro.config file at packages/expo/src/generators/application/files/metro.config.js.template and packages/react-native/src/generators/application/files/app/metro.config.js.template? |
yzhe554
force-pushed
the
feature/support-cjs-and-mjs
branch
from
19140fc to
c11c3db
Compare
Contributor
Author
xiongemi
approved these changes
Feb 5, 2024
FrozenPandaz
pushed a commit
that referenced
this pull request
Feb 9, 2024
Co-authored-by: Miroslav Jonaš <missing.manual@gmail.com> (cherry picked from commit bf45f08)
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
The init script won't support cjs and mjs by default
Expected Behavior
There are some third party libraries are using cjs and mjs, for user's benefits, support cjs and mjs by default.
Related Issue(s)
Fixes #