Skip to content

Commit 8994496

Browse files
AgentEnderFrozenPandaz
authored andcommitted
fix(core): use black for all fg elements when in light theme (#32415)
## Current Behavior We use dark gray for a secondary fg color, but when dimmed and in certain terminals its not easy to read for light mode ## Expected Behavior We've struggled with getting this pallet right for a while, while we continue working on it we'll just set it to all black ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes # (cherry picked from commit 885a3d5)
1 parent 726de02 commit 8994496

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

packages/nx/src/native/tui/theme.rs

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
#![allow(clippy::disallowed_types)]
33

44
// This is the only file we should use the `ratatui::style::Color` type in
5-
use ratatui::style::Color;
5+
use ratatui::style::{Color, Style};
66
use std::sync::LazyLock;
77
use terminal_colorsaurus::{ColorScheme, QueryOptions, color_scheme};
88
use tracing::debug;
@@ -36,7 +36,8 @@ impl Theme {
3636
fn dark() -> Self {
3737
Self {
3838
is_dark_mode: true,
39-
primary_fg: Color::White,
39+
// reset => default foreground color
40+
primary_fg: Color::Reset,
4041
secondary_fg: Color::Gray,
4142
error: Color::Red,
4243
success: Color::Green,
@@ -49,7 +50,8 @@ impl Theme {
4950
fn light() -> Self {
5051
Self {
5152
is_dark_mode: false,
52-
primary_fg: Color::Black,
53+
// reset => default foreground color
54+
primary_fg: Color::Reset,
5355
secondary_fg: Color::DarkGray,
5456
error: Color::Red,
5557
success: Color::Green,

0 commit comments

Comments
 (0)