Skip to content

Commit 51cd35c

Browse files
authored
feat(expo): upgrade expo-cli to 6.3.0 (#14944)
1 parent dfc424d commit 51cd35c

File tree

4 files changed

+36
-5
lines changed

4 files changed

+36
-5
lines changed

e2e/expo/src/expo.test.ts

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ describe('expo', () => {
2020
);
2121
afterEach(() => cleanupProject());
2222

23-
it('should test, lint, export and prebuild', async () => {
23+
it('should test, lint, export, export-web and prebuild', async () => {
2424
const appName = uniq('my-app');
2525
const libName = uniq('lib');
2626
const componentName = uniq('component');
@@ -52,6 +52,13 @@ describe('expo', () => {
5252
expect(exportResults.combinedOutput).toContain(
5353
'Export was successful. Your exported files can be found'
5454
);
55+
checkFilesExist(`dist/apps/${appName}/metadata.json`);
56+
57+
expect(() => {
58+
runCLI(`export-web ${appName}`);
59+
checkFilesExist(`apps/${appName}/web-build/index.html`);
60+
checkFilesExist(`apps/${appName}/web-build/manifest.json`);
61+
}).not.toThrow();
5562

5663
// set a mock package name for ios and android in expo's app.json
5764
const workspace = readResolvedConfiguration();

packages/expo/migrations.json

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -602,6 +602,23 @@
602602
"alwaysAddToPackageJson": false
603603
}
604604
}
605+
},
606+
"15.7.2": {
607+
"version": "15.7.2-beta.0",
608+
"packages": {
609+
"@expo/webpack-config": {
610+
"version": "~18.0.1",
611+
"alwaysAddToPackageJson": false
612+
},
613+
"eas-cli": {
614+
"version": "3.5.2",
615+
"alwaysAddToPackageJson": false
616+
},
617+
"expo-cli": {
618+
"version": "6.3.0",
619+
"alwaysAddToPackageJson": false
620+
}
621+
}
605622
}
606623
}
607624
}

packages/expo/plugins/with-nx-webpack.ts

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import { TsconfigPathsPlugin } from 'tsconfig-paths-webpack-plugin';
22
import { resolve } from 'path';
33

44
/**
5-
* This function add addtional rules to expo's webpack config to make expo web working
5+
* This function add additional rules to expo's webpack config to make expo web working
66
*/
77
export async function withNxWebpack(config) {
88
// add additional rule to load files under libs
@@ -27,6 +27,13 @@ export async function withNxWebpack(config) {
2727
});
2828
}
2929

30+
if (!config.resolve) {
31+
config.resolve = {};
32+
}
33+
if (!config.resolve.plugins) {
34+
config.resolve.plugins = [];
35+
}
36+
3037
const extensions = ['.ts', '.tsx', '.mjs', '.js', '.jsx'];
3138
const tsConfigPath = resolve('tsconfig.json');
3239

packages/expo/src/utils/versions.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,12 @@ export const nxVersion = require('../../package.json').version;
22

33
export const expoVersion = '47.0.13';
44
export const expoMetroConfigVersion = '0.5.2';
5-
export const expoWebpackConfig = '~0.17.4';
5+
export const expoWebpackConfig = '~18.0.1';
66
export const expoSplashScreenVersion = '~0.17.5';
77
export const expoStatusBarVersion = '~1.4.2';
8-
export const deprecatedExpoCliVersion = '6.1.0'; // expo-cli
8+
export const deprecatedExpoCliVersion = '6.3.0'; // expo-cli
99
export const expoCliVersion = '0.4.11'; // @expo/cli
10-
export const easCliVersion = '3.3.2';
10+
export const easCliVersion = '3.5.2';
1111
export const babelPresetExpoVersion = '~9.2.2';
1212

1313
export const reactVersion = '18.1.0';

0 commit comments

Comments
 (0)