fix(vite): add tslib as a dep for @nx/vite and remove @swc/helpers (#32341)

When we switched to the TS solution setup with inferred `tsc` builds, we
didn't update the dependencies for `@nx/vite` to use `tslib` instead of
`@swc/helpers`. It was previously using `@nx/js:swc` executor, but now
`build-base` target is inferred as `tsc -b`.

It did not cause issues since other packages including `nx` always
install tslib, but technically it is incorrect, and we were ignoring the
errors by adding `tslib` and `@swc/helpers` to be ignored in
`.eslintrc.json`.

This PR also cleans up the eslint config for all other packages since we
do not need to ignore `tslib` for `@nx/dependency-checks` to pass.

<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

<!-- If this is a particularly complex change or feature addition, you
can request a dedicated Nx release for this pull request branch. Mention
someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they
will confirm if the PR warrants its own release for testing purposes,
and generate it for you if appropriate. -->

## Current Behavior
`@nx/vite` is missing `tslib` dependency even though the built JS file
uses it.

## Expected Behavior
Should have `tslib` as a dependency and not `@swc/helpers`.

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #

Author: jaysoo

packages/angular-rspack-compiler/.eslintrc.json

@@ -37,6 +37,7 @@
         "@nx/dependency-checks": [
           "error",
           {
+            "buildTargets": ["build-base"],
             "ignoredFiles": [
               "{projectRoot}/.eslintrc.json",
               "{projectRoot}/vite.config.{js,ts,mjs,mts}"
@@ -45,8 +46,7 @@
               "@angular/core",
               "jsonc-eslint-parser",
               "vitest",
-              "memfs",
-              "tslib"
+              "memfs"
             ]
           }
         ]

packages/angular-rspack/.eslintrc.json

@@ -37,6 +37,7 @@
         "@nx/dependency-checks": [
           "error",
           {
+            "buildTargets": ["build-base"],
             "ignoredFiles": [
               "{projectRoot}/.eslintrc.json",
               "{projectRoot}/vite.config.{js,ts,mjs,mts}"
@@ -46,7 +47,6 @@
               "jsonc-eslint-parser",
               "vitest",
               "memfs",
-              "tslib",
               // it's only a type import, so it won't be required at runtime
               "sass",
               // shown as unused because it's required using `createRequire`

packages/angular/.eslintrc.json

@@ -51,7 +51,6 @@
           {
             "buildTargets": ["build-base"],
             "ignoredDependencies": [
-              "tslib",
               "@angular-devkit/architect",
               "@angular-devkit/schematics",
               "@nx/cypress",

packages/create-nx-plugin/.eslintrc.json

@@ -41,7 +41,7 @@
           "error",
           {
             "buildTargets": ["build-base"],
-            "ignoredDependencies": ["tslib"]
+            "ignoredDependencies": []
           }
         ]
       }

packages/create-nx-workspace/.eslintrc.json

@@ -33,7 +33,7 @@
           "error",
           {
             "buildTargets": ["build-base"],
-            "ignoredDependencies": ["tslib"]
+            "ignoredDependencies": []
           }
         ]
       }

packages/cypress/.eslintrc.json

@@ -34,7 +34,6 @@
           {
             "buildTargets": ["build-base"],
             "ignoredDependencies": [
-              "tslib",
               "nx",
               "typescript",
               // Type imports only

packages/detox/.eslintrc.json

@@ -23,7 +23,7 @@
           "error",
           {
             "buildTargets": ["build-base"],
-            "ignoredDependencies": ["nx", "tslib", "typescript", "detox"]
+            "ignoredDependencies": ["nx", "typescript", "detox"]
           }
         ]
       }

packages/devkit/.eslintrc.json

@@ -69,7 +69,6 @@
               "nx",
               "typescript",
               "prettier",
-              "tslib",
               // Installed to workspace by plugins
               "rxjs",
               "@angular-devkit/core",

packages/esbuild/.eslintrc.json

@@ -45,7 +45,7 @@
           "error",
           {
             "buildTargets": ["build-base"],
-            "ignoredDependencies": ["nx", "tslib", "typescript", "esbuild"]
+            "ignoredDependencies": ["nx", "typescript", "esbuild"]
           }
         ]
       }

packages/eslint-plugin/.eslintrc.json

@@ -32,7 +32,6 @@
           {
             "buildTargets": ["build-base"],
             "ignoredDependencies": [
-              "tslib",
               "nx",
               "typescript",
               // Installed to workspace by plugins