-
Notifications
You must be signed in to change notification settings - Fork 236
chore(repo): update nx to 22.3.0-beta.1 #2907
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
View your CI Pipeline Execution ↗ for commit e02c269
☁️ Nx Cloud last updated this comment at |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nx Cloud is proposing a fix for your failed CI:
These changes fix the TypeScript compilation errors across shared-npm:typecheck, nx-mcp:build:production, and vscode:build:ci by adding the missing 'why' property to the PackageManagerCommands fallback implementation. The Nx upgrade to 22.3.0-beta.2 introduced a new required 'why' property in the PackageManagerCommands interface, and we've added the correct npm command ('npm explain') to satisfy this requirement.
We verified this fix by re-running shared-npm:typecheck.
diff --git a/libs/shared/npm/src/lib/local-nx-utils/package-manager-command.ts b/libs/shared/npm/src/lib/local-nx-utils/package-manager-command.ts
index 9fa14f24..63d1f68d 100644
--- a/libs/shared/npm/src/lib/local-nx-utils/package-manager-command.ts
+++ b/libs/shared/npm/src/lib/local-nx-utils/package-manager-command.ts
@@ -88,6 +88,7 @@ export async function getPackageManagerCommand(
run: (script: any, args: any) =>
`npm run ${script}${args ? ' -- ' + args : ''}`,
list: 'npm ls',
+ why: 'npm explain',
getRegistryUrl: 'npm config get registry',
publish: (packageRoot, registry, registryConfigKey, tag) =>
`npm publish "${packageRoot}" --json --"${registryConfigKey}=${registry}" --tag=${tag}`,
Or Apply changes locally with:
npx nx-cloud apply-locally jcOP-Mfod
Apply fix locally with your editor ↗ View interactive diff ↗
🎓 Learn more about Self-Healing CI on nx.dev
Updating Nx from 22.1.0-rc.5 to 22.3.0-beta.1