Skip to content

Allow to add suffix overlays #2913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

tomchy
Copy link
Contributor

@tomchy tomchy commented May 26, 2025

Allow to add an image-specific DTS overlay, that is applied based on the FILE_SUFFIX.
Up to this point, it was possible to specify such Kconfig files (sysbuild/<image>_<file_suffix>.conf), but it did not work with dts overlays (sysbuild/<image>_<file_suffix>.overlay).
This commit aligns the logic of finding configuration files for both scenarios mentioned above.

Ref: NCSDK-NONE

@tomchy tomchy force-pushed the bugfix/sysbuild/NCSDK-NONE_Allow_to_add_suffix_overlays branch 2 times, most recently from 824613e to 41f4d91 Compare May 27, 2025 07:52
@tomchy tomchy requested review from nordicjm and ahasztag May 27, 2025 07:52
@tomchy tomchy force-pushed the bugfix/sysbuild/NCSDK-NONE_Allow_to_add_suffix_overlays branch from 41f4d91 to cefb313 Compare May 27, 2025 08:43
@tomchy tomchy requested a review from nordicjm May 27, 2025 08:45
@tomchy tomchy force-pushed the bugfix/sysbuild/NCSDK-NONE_Allow_to_add_suffix_overlays branch from cefb313 to 4ea8f4f Compare May 27, 2025 09:45
@tomchy tomchy requested a review from nordicjm May 27, 2025 09:47
@tomchy tomchy force-pushed the bugfix/sysbuild/NCSDK-NONE_Allow_to_add_suffix_overlays branch from 4ea8f4f to ce220dd Compare May 29, 2025 09:49
Allow to add an image-specific DTS overlay, that is applied based on the
FILE_SUFFIX.
Up to this point, it was possible to specify such Kconfig files
(sysbuild/<image>_<file_suffix>.conf),
but it did not work with dts overlays
(sysbuild/<image>_<file_suffix>.overlay).
This commit aligns the logic of finding configuration files for both
scenarios mentioned above.

Ref: NCSDK-NONE

Upstream PR #: 90643

Signed-off-by: Tomasz Chyrowicz <tomasz.chyrowicz@nordicsemi.no>
@tomchy tomchy force-pushed the bugfix/sysbuild/NCSDK-NONE_Allow_to_add_suffix_overlays branch from ce220dd to c76fd63 Compare May 29, 2025 13:00
Copy link

@rlubos rlubos merged commit ef44738 into nrfconnect:main May 30, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants