feat: add nameserver.ListWithParams #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Introduce NameserverListRequest struct, mapping to 2.15.10.nameserver.list. * Convert nameserver/List to use this NameserverListRequest instead.
sadly you cannot change the name of an exported element because it will break the lib API. It's the same thing for the method signature. |
ldez
changed the title
|
thanks and makes sense. |
|
I created a new tag v0.9.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
While trying to use nameserver/List in StackExchange/dnscontrol#2577, we discovered that nameserver.go/List is not following the struct-as-request paradigm that allows for setting all input fields, as most other methods do.
This PR:
NameserverListRequest, mirroring the List input fields in inwx API* Changes List() to use NameserverListRequest for input fields.* Fixes a few mostly-internal typos (Namserver* -> Nameserver*)Thanks!