Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] lint script broken #359

Closed
1 task done
rotu opened this issue Sep 14, 2023 · 1 comment · Fixed by #364
Closed
1 task done

[BUG] lint script broken #359

rotu opened this issue Sep 14, 2023 · 1 comment · Fixed by #364
Labels
Needs Triage needs an initial review

Comments

@rotu
Copy link
Contributor

rotu commented Sep 14, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

npm run lint

> @npmcli/template-oss@4.18.0 lint
> eslint "**/*.js"


Oops! Something went wrong! :(

ESLint: 8.49.0

Error: ESLint configuration in test\apply\tap-testdir-files-snapshots-turn-off-specific-files\.eslintrc.yml is invalid:
        - Property "" is the wrong type (expected object but got `"exists"`).

    at ConfigValidator.validateConfigSchema (C:\Users\dan\Source\template-oss\node_modules\@eslint\eslintrc\dist\eslintrc.cjs:2168:19)
    at ConfigArrayFactory._normalizeConfigData (C:\Users\dan\Source\template-oss\node_modules\@eslint\eslintrc\dist\eslintrc.cjs:3010:19)
    at ConfigArrayFactory.loadInDirectory (C:\Users\dan\Source\template-oss\node_modules\@eslint\eslintrc\dist\eslintrc.cjs:2878:33)
    at CascadingConfigArrayFactory._loadConfigInAncestors (C:\Users\dan\Source\template-oss\node_modules\@eslint\eslintrc\dist\eslintrc.cjs:3860:46)
    at CascadingConfigArrayFactory.getConfigArrayForFile (C:\Users\dan\Source\template-oss\node_modules\@eslint\eslintrc\dist\eslintrc.cjs:3781:18)
    at FileEnumerator._iterateFilesRecursive (C:\Users\dan\Source\template-oss\node_modules\eslint\lib\cli-engine\file-enumerator.js:450:49)
    at _iterateFilesRecursive.next (<anonymous>)
    at FileEnumerator._iterateFilesRecursive (C:\Users\dan\Source\template-oss\node_modules\eslint\lib\cli-engine\file-enumerator.js:497:33)
    at _iterateFilesRecursive.next (<anonymous>)
    at FileEnumerator._iterateFilesRecursive (C:\Users\dan\Source\template-oss\node_modules\eslint\lib\cli-engine\file-enumerator.js:497:33)

Expected Behavior

No response

Steps To Reproduce

  1. In this environment...
  2. With this config...
  3. Run '...'
  4. See error...

Environment

  • npm:
  • Node:
  • OS: Windows 11
  • platform:
@rotu rotu added the Needs Triage needs an initial review label Sep 14, 2023
@rotu
Copy link
Contributor Author

rotu commented Sep 14, 2023 •
edited
Loading

This seems to happen if you run npx tap -- --save-fixture then npm run lint. It is not fixed by simply adding tap-testdir*/ to .gitignore per #350.

@rotu rotu mentioned this issue Sep 14, 2023
Closed
@wraithgar wraithgar mentioned this issue Sep 15, 2023
Merged
wraithgar added a commit that referenced this issue Sep 15, 2023
@wraithgar
fix: Ignore transient tap test directories (#364)
29bf19d 
Running tests causes a lot of file churn. Although (usually) ephemeral,
these files cause high CPU usage and can make developer tools difficult
to use. These files also make linting fail.

Now the files will be ignored by git and by eslint.

## References
Fixes #348
Fixes #359

This is a rebase of #350 since it had yet another conflict.

---------

Authored-by: Dan <DanOfTheRoses@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Needs Triage needs an initial review
Projects
None yet
Milestone
No milestone
1 participant
@rotu