File tree 2 files changed +7
-22
lines changed
2 files changed +7
-22
lines changed Original file line number Diff line number Diff line change @@ -53,28 +53,6 @@ module.exports = class extends ManifestPlugin {
53
53
return `${ link ( scope , url ) } : ${ wrapSpecs ( `${ name } @${ version } ` ) } `
54
54
} )
55
55
56
- // remove the other release please dependencies list which always starts with
57
- // the following line and then each line is indented. so we search for the line
58
- // and remove and indented lines until the next non indented line.
59
- let foundRemoveStart = false
60
- let foundRemoveEnd = false
61
- release . notes = release . notes
62
- . split ( '\n' )
63
- . filter ( ( line ) => {
64
- if ( line === '* The following workspace dependencies were updated' ) {
65
- foundRemoveStart = true
66
- } else if ( foundRemoveStart && ! foundRemoveEnd ) {
67
- // TODO: test when inserted dependencies is not the last thing in the changelog
68
- /* istanbul ignore next */
69
- if ( ! line || ! line . startsWith ( ' ' ) ) {
70
- foundRemoveEnd = true
71
- }
72
- }
73
- // If we found the start, remove all lines until we've found the end
74
- return foundRemoveStart ? foundRemoveEnd : true
75
- } )
76
- . join ( '\n' )
77
-
78
56
// Find the associated changelog and update that too
79
57
const path = this . #pathsByComponent. get ( release . component )
80
58
for ( const update of candidate . pullRequest . updates ) {
Original file line number Diff line number Diff line change @@ -12,6 +12,13 @@ const { WORKSPACE_MESSAGE } = require('./node-workspace-format')
12
12
// release-please ourselves.
13
13
/* istanbul ignore next: TODO fix flaky tests and enable coverage */
14
14
class NpmNodeWorkspace extends NodeWorkspace {
15
+ updateCandidate ( pr ) {
16
+ // no-op so release-please node-workspace plugin does not add
17
+ // its broken changelog to the workspace releases. our changelog
18
+ // formatting and the preconfigure method below fix this.
19
+ return pr
20
+ }
21
+
15
22
async preconfigure ( strategiesByPath , commitsByPath , releasesByPath ) {
16
23
// First build a list of all releases that will happen based on the
17
24
// conventional commits
You can’t perform that action at this time.
0 commit comments